track when a special stack trace symbolication occurs

Author: vzaidman

front_end/core/host/RNPerfMetrics.ts

@@ -270,6 +270,15 @@ class RNPerfMetrics {
     });
   }
 
+  stackTraceParsedWithHermesFrame(frameType: string): void {
+    this.sendEvent({
+      eventName: 'StackTraceParsedWithHermesFrame',
+      params: {
+        frameType,
+      },
+    });
+  }
+
   panelShown(_panelName: string, _isLaunching?: boolean): void {
     // no-op
     // We only care about the "main" and "drawer" panels for now via panelShownInLocation(…)
@@ -443,10 +452,18 @@ export type StackTraceSymbolicationFailed = Readonly<{
   }>,
 }>;
 
+export type StackTraceParsedWithHermesFrame = Readonly<{
+  eventName: 'StackTraceParsedWithHermesFrame',
+  params: Readonly<{
+    frameType: string,
+  }>,
+}>;
+
 export type ReactNativeChromeDevToolsEvent =
     EntrypointLoadingStartedEvent|EntrypointLoadingFinishedEvent|DebuggerReadyEvent|BrowserVisibilityChangeEvent|
     BrowserErrorEvent|RemoteDebuggingTerminatedEvent|DeveloperResourceLoadingStartedEvent|
     DeveloperResourceLoadingFinishedEvent|FuseboxSetClientMetadataStartedEvent|FuseboxSetClientMetadataFinishedEvent|
-    MemoryPanelActionStartedEvent|MemoryPanelActionFinishedEvent|PanelShownEvent|PanelClosedEvent|StackTraceSymbolicationFailed;
+    MemoryPanelActionStartedEvent|MemoryPanelActionFinishedEvent|PanelShownEvent|PanelClosedEvent|
+    StackTraceSymbolicationFailed|StackTraceParsedWithHermesFrame;
 
 export type DecoratedReactNativeChromeDevToolsEvent = CommonEventFields&ReactNativeChromeDevToolsEvent;

front_end/panels/console/ErrorStackParser.ts

@@ -79,7 +79,7 @@ export function parseSourcePositionsFromErrorStack(
 
     const linkCandidate = line.substring(left, right);
     const splitResult = Common.ParsedURL.ParsedURL.splitLineAndColumn(linkCandidate);
-    if (splitResult.url === '<anonymous>' || splitResult.url === 'native') {
+    if (splitResult.url === '<anonymous>') {
       if (linkInfos.length && linkInfos[linkInfos.length - 1].isCallFrame && !linkInfos[linkInfos.length - 1].link) {
         // Combine builtin frames.
         linkInfos[linkInfos.length - 1].line += `\n${line}`;
@@ -110,6 +110,13 @@ export function parseSourcePositionsFromErrorStack(
       },
     });
   }
+
+  if (linkInfos?.length) {
+    if (linkInfos.some(({line}) => /at .*\(native\)$/.test(line))) {
+      Host.rnPerfMetrics.stackTraceParsedWithHermesFrame('native frame');
+    }
+  }
+
   return linkInfos;
 }