diff --git a/source/test/CcspAdvSecurityDmlTest/CcspAdvSecurityDmlTest.cpp b/source/test/CcspAdvSecurityDmlTest/CcspAdvSecurityDmlTest.cpp index ab195a1..bded224 100644 --- a/source/test/CcspAdvSecurityDmlTest/CcspAdvSecurityDmlTest.cpp +++ b/source/test/CcspAdvSecurityDmlTest/CcspAdvSecurityDmlTest.cpp @@ -21,67 +21,12 @@ typedef void* ANSC_HANDLE; ANSC_HANDLE bus_handle = NULL; - -class CcspAdvSecurityDmlTestFixture : public ::testing::Test { -protected: - void SetUp() override { - g_syscfgMock = new SyscfgMock(); - g_securewrapperMock = new SecureWrapperMock(); - g_msgpackMock = new msgpackMock(); - g_usertimeMock = new UserTimeMock(); - g_safecLibMock = new SafecLibMock(); - g_anscMemoryMock = new AnscMemoryMock(); - g_baseapiMock = new BaseAPIMock(); - g_traceMock = new TraceMock(); - g_base64Mock = new base64Mock(); - g_rbusMock = new rbusMock(); - g_cmHALMock = new CmHalMock(); - g_platformHALMock = new PlatformHalMock(); - g_cjsonMock = new cjsonMock(); - g_syseventMock = new SyseventMock(); - g_webconfigFwMock = new webconfigFwMock(); - g_anscWrapperApiMock = new AnscWrapperApiMock(); - } - - void TearDown() override { - delete g_syscfgMock; - delete g_securewrapperMock; - delete g_msgpackMock; - delete g_usertimeMock; - delete g_safecLibMock; - delete g_anscMemoryMock; - delete g_baseapiMock; - delete g_traceMock; - delete g_base64Mock; - delete g_rbusMock; - delete g_cmHALMock; - delete g_platformHALMock; - delete g_cjsonMock; - delete g_syseventMock; - delete g_webconfigFwMock; - delete g_anscWrapperApiMock; - g_syscfgMock = nullptr; - g_securewrapperMock = nullptr; - g_msgpackMock = nullptr; - g_usertimeMock = nullptr; - g_safecLibMock = nullptr; - g_anscMemoryMock = nullptr; - g_baseapiMock = nullptr; - g_traceMock = nullptr; - g_base64Mock = nullptr; - g_rbusMock = nullptr; - g_cmHALMock = nullptr; - g_platformHALMock = nullptr; - g_cjsonMock = nullptr; - g_syseventMock = nullptr; - g_webconfigFwMock = nullptr; - g_anscWrapperApiMock = nullptr; - } +class CcspAdvSecurityDmlTestFixture : public CcspAdvSecurityTestBase { }; -TEST_F(CcspAdvSecurityDmlTestFixture, CheckDeviceFingerPrint_GetParamBoolValue_Enable) { +TEST_F(CcspAdvSecurityDmlTestFixture, DeviceFingerPrint_GetParamBoolValue_Enable) { BOOL resultBool; - PCOSA_DATAMODEL_AGENT pMyObject = new COSA_DATAMODEL_AGENT; + PCOSA_DATAMODEL_AGENT pMyObject = (PCOSA_DATAMODEL_AGENT)calloc(1, sizeof(COSA_DATAMODEL_AGENT)); pMyObject->bEnable = TRUE; g_pAdvSecAgent = pMyObject; @@ -97,12 +42,12 @@ TEST_F(CcspAdvSecurityDmlTestFixture, CheckDeviceFingerPrint_GetParamBoolValue_E EXPECT_TRUE(result); EXPECT_TRUE(resultBool); - delete pMyObject; + free(pMyObject); } -TEST_F(CcspAdvSecurityDmlTestFixture, CheckDeviceFingerPrint_GetParamBoolValue_Disable) { +TEST_F(CcspAdvSecurityDmlTestFixture, DeviceFingerPrint_GetParamBoolValue_Disable) { BOOL resultBool; - PCOSA_DATAMODEL_AGENT pMyObject = new COSA_DATAMODEL_AGENT; + PCOSA_DATAMODEL_AGENT pMyObject = (PCOSA_DATAMODEL_AGENT)calloc(1, sizeof(COSA_DATAMODEL_AGENT)); pMyObject->bEnable = FALSE; g_pAdvSecAgent = pMyObject; @@ -118,12 +63,12 @@ TEST_F(CcspAdvSecurityDmlTestFixture, CheckDeviceFingerPrint_GetParamBoolValue_D EXPECT_TRUE(result); EXPECT_FALSE(resultBool); - delete pMyObject; + free(pMyObject); } -TEST_F(CcspAdvSecurityDmlTestFixture, CheckDeviceFingerPrint_GetParamBoolValue_UnsupportedParam) { +TEST_F(CcspAdvSecurityDmlTestFixture, DeviceFingerPrint_GetParamBoolValue_UnsupportedParam) { BOOL resultBool; - PCOSA_DATAMODEL_AGENT pMyObject = new COSA_DATAMODEL_AGENT; + PCOSA_DATAMODEL_AGENT pMyObject = (PCOSA_DATAMODEL_AGENT)calloc(1, sizeof(COSA_DATAMODEL_AGENT)); g_pAdvSecAgent = pMyObject; const char* ParamName = "UnsupportedParam"; @@ -137,13 +82,13 @@ TEST_F(CcspAdvSecurityDmlTestFixture, CheckDeviceFingerPrint_GetParamBoolValue_U EXPECT_FALSE(result); - delete pMyObject; + free(pMyObject); } -TEST_F(CcspAdvSecurityDmlTestFixture, CheckDeviceFingerPrint_SetParamBoolValue_Enable) { +TEST_F(CcspAdvSecurityDmlTestFixture, DeviceFingerPrint_SetParamBoolValue_Enable) { const char *DeviceFingerPrintEnabled = "Advsecurity_DeviceFingerPrint"; - PCOSA_DATAMODEL_AGENT pMyObject = new COSA_DATAMODEL_AGENT; + PCOSA_DATAMODEL_AGENT pMyObject = (PCOSA_DATAMODEL_AGENT)calloc(1, sizeof(COSA_DATAMODEL_AGENT)); pMyObject->bEnable = FALSE; g_pAdvSecAgent = pMyObject; @@ -175,12 +120,12 @@ TEST_F(CcspAdvSecurityDmlTestFixture, CheckDeviceFingerPrint_SetParamBoolValue_E EXPECT_TRUE(result); EXPECT_TRUE(pMyObject->bEnable); - delete pMyObject; + free(pMyObject); } -TEST_F(CcspAdvSecurityDmlTestFixture, CheckDeviceFingerPrint_SetParamBoolValue_Disable) { +TEST_F(CcspAdvSecurityDmlTestFixture, DeviceFingerPrint_SetParamBoolValue_Disable) { const char *DeviceFingerPrintEnabled = "Advsecurity_DeviceFingerPrint"; - PCOSA_DATAMODEL_AGENT pMyObject = new COSA_DATAMODEL_AGENT; + PCOSA_DATAMODEL_AGENT pMyObject = (PCOSA_DATAMODEL_AGENT)calloc(1, sizeof(COSA_DATAMODEL_AGENT)); pMyObject->bEnable = TRUE; g_pAdvSecAgent = pMyObject; @@ -212,12 +157,12 @@ TEST_F(CcspAdvSecurityDmlTestFixture, CheckDeviceFingerPrint_SetParamBoolValue_D EXPECT_TRUE(result); EXPECT_FALSE(pMyObject->bEnable); - delete pMyObject; + free(pMyObject); } -TEST_F(CcspAdvSecurityDmlTestFixture, CheckDeviceFingerPrint_GetParamUlongValue_LoggingPeriod) { +TEST_F(CcspAdvSecurityDmlTestFixture, DeviceFingerPrint_GetParamUlongValue_LoggingPeriod) { ULONG resultUlong; - PCOSA_DATAMODEL_AGENT pMyObject = new COSA_DATAMODEL_AGENT; + PCOSA_DATAMODEL_AGENT pMyObject = (PCOSA_DATAMODEL_AGENT)calloc(1, sizeof(COSA_DATAMODEL_AGENT)); pMyObject->ulLoggingPeriod = 100; g_pAdvSecAgent = pMyObject; @@ -233,11 +178,11 @@ TEST_F(CcspAdvSecurityDmlTestFixture, CheckDeviceFingerPrint_GetParamUlongValue_ EXPECT_TRUE(result); EXPECT_EQ(100, resultUlong); - delete pMyObject; + free(pMyObject); } -TEST_F(CcspAdvSecurityDmlTestFixture, CheckDeviceFingerPrint_SetParamUlongValue_LoggingPeriod) { - PCOSA_DATAMODEL_AGENT pMyObject = new COSA_DATAMODEL_AGENT; +TEST_F(CcspAdvSecurityDmlTestFixture, DeviceFingerPrint_SetParamUlongValue_LoggingPeriod) { + PCOSA_DATAMODEL_AGENT pMyObject = (PCOSA_DATAMODEL_AGENT)calloc(1, sizeof(COSA_DATAMODEL_AGENT)); pMyObject->ulLoggingPeriod = 100; g_pAdvSecAgent = pMyObject; const char *DeviceFingerPrintLogginPeriod = "Advsecurity_LoggingPeriod"; @@ -267,10 +212,10 @@ TEST_F(CcspAdvSecurityDmlTestFixture, CheckDeviceFingerPrint_SetParamUlongValue_ EXPECT_TRUE(result); EXPECT_EQ(200, pMyObject->ulLoggingPeriod); - delete pMyObject; + free(pMyObject); } -TEST_F(CcspAdvSecurityDmlTestFixture, CheckDeviceFingerPrint_GetParamStringValue_EndpointURL) { +TEST_F(CcspAdvSecurityDmlTestFixture, DeviceFingerPrint_GetParamStringValue_EndpointURL) { char pValue[256] = {0}; ULONG pUlSize = 256; ANSC_STATUS returnStatus = ANSC_STATUS_SUCCESS; @@ -305,7 +250,7 @@ TEST_F(CcspAdvSecurityDmlTestFixture, CheckDeviceFingerPrint_GetParamStringValue EXPECT_EQ(ANSC_STATUS_SUCCESS, returnStatus); } -TEST_F(CcspAdvSecurityDmlTestFixture, CheckDeviceFingerPrint_SetParamStringValue_EndpointURL) { +TEST_F(CcspAdvSecurityDmlTestFixture, DeviceFingerPrint_SetParamStringValue_EndpointURL) { char pString[256] = "\0"; const char *AdvSecCustomEndpointURL = "Advsecurity_CustomEndpointURL"; ANSC_STATUS returnStatus = ANSC_STATUS_SUCCESS; diff --git a/source/test/CcspAdvSecurityDmlTest/CcspAdvSecurityInternalTest.cpp b/source/test/CcspAdvSecurityDmlTest/CcspAdvSecurityInternalTest.cpp index 0f3b8e2..fd15f8f 100644 --- a/source/test/CcspAdvSecurityDmlTest/CcspAdvSecurityInternalTest.cpp +++ b/source/test/CcspAdvSecurityDmlTest/CcspAdvSecurityInternalTest.cpp @@ -18,62 +18,7 @@ #include "CcspAdvSecurityMock.h" -class CcspAdvSecurityInternalTestFixture : public ::testing::Test { -protected: - void SetUp() override { - - g_syscfgMock = new SyscfgMock(); - g_securewrapperMock = new SecureWrapperMock(); - g_msgpackMock = new msgpackMock(); - g_usertimeMock = new UserTimeMock(); - g_safecLibMock = new SafecLibMock(); - g_anscMemoryMock = new AnscMemoryMock(); - g_baseapiMock = new BaseAPIMock(); - g_traceMock = new TraceMock(); - g_base64Mock = new base64Mock(); - g_rbusMock = new rbusMock(); - g_cmHALMock = new CmHalMock(); - g_platformHALMock = new PlatformHalMock(); - g_cjsonMock = new cjsonMock(); - g_syseventMock = new SyseventMock(); - g_webconfigFwMock = new webconfigFwMock(); - g_anscWrapperApiMock = new AnscWrapperApiMock(); - } - - void TearDown() override { - delete g_syscfgMock; - delete g_securewrapperMock; - delete g_msgpackMock; - delete g_usertimeMock; - delete g_safecLibMock; - delete g_anscMemoryMock; - delete g_baseapiMock; - delete g_traceMock; - delete g_base64Mock; - delete g_rbusMock; - delete g_cmHALMock; - delete g_platformHALMock; - delete g_cjsonMock; - delete g_syseventMock; - delete g_webconfigFwMock; - delete g_anscWrapperApiMock; - g_syscfgMock = nullptr; - g_securewrapperMock = nullptr; - g_msgpackMock = nullptr; - g_usertimeMock = nullptr; - g_safecLibMock = nullptr; - g_anscMemoryMock = nullptr; - g_baseapiMock = nullptr; - g_traceMock = nullptr; - g_base64Mock = nullptr; - g_rbusMock = nullptr; - g_cmHALMock = nullptr; - g_platformHALMock = nullptr; - g_cjsonMock = nullptr; - g_syseventMock = nullptr; - g_webconfigFwMock = nullptr; - g_anscWrapperApiMock = nullptr; - } +class CcspAdvSecurityInternalTestFixture : public CcspAdvSecurityTestBase { }; TEST_F(CcspAdvSecurityInternalTestFixture, ccsp_advsec_start_features_sb) { @@ -94,16 +39,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, ccsp_advsec_start_features_sb) { g_pAdvSecAgent->bEnable = TRUE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvSecuritySBEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -start sb null &"), _)) - .Times(1) .WillOnce(Return(0)); if ((file = fopen(fname, "r"))) { @@ -148,16 +89,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, ccsp_advsec_start_features_sf) { g_pAdvSecAgent->bEnable = TRUE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvSecuritySFEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -start null sf &"), _)) - .Times(1) .WillOnce(Return(0)); if ((file = fopen(fname, "r"))) { @@ -209,16 +146,13 @@ TEST_F(CcspAdvSecurityInternalTestFixture, ccsp_advsec_start_features_sb_sf) { .Times(2) .WillRepeatedly(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvSecuritySBEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvSecuritySFEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) .Times(2) .WillRepeatedly(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -start sb sf &"), _)) - .Times(1) .WillOnce(Return(0)); if ((file = fopen(fname, "r"))) @@ -268,16 +202,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, ccsp_advsec_stop_features_sb) { g_pAdvSecAgent->bEnable = TRUE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvSecuritySBEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -stop sb null &"), _)) - .Times(1) .WillOnce(Return(0)); if ((file = fopen(fname, "r"))) @@ -325,16 +255,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, ccsp_advsec_stop_features_sf) { g_pAdvSecAgent->bEnable = TRUE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvSecuritySFEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -stop null sf &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvSecStopFeatures(type); @@ -369,16 +295,13 @@ TEST_F(CcspAdvSecurityInternalTestFixture, ccsp_advsec_stop_features_sb_sf) { .Times(2) .WillRepeatedly(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvSecuritySBEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvSecuritySFEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) .Times(2) .WillRepeatedly(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -stop sb sf &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvSecStopFeatures(type); @@ -404,16 +327,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, Cosa_AdvSec_Agent_Raptr_Init) { g_pAdvSecAgent->pRaptr_RFC->bEnable = TRUE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(RaptrEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -enableRaptr &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvSecAgentRaptrInit(g_pAdvSecAgent->pRaptr_RFC); @@ -436,16 +355,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, Cosa_AdvSec_Agent_Raptr_DeInit) { g_pAdvSecAgent->pRaptr_RFC->bEnable = FALSE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(RaptrEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -disableRaptr &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvSecAgentRaptrDeInit(g_pAdvSecAgent->pRaptr_RFC); @@ -472,16 +387,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, ccsp_start_privacy_protection) { g_pAdvSecAgent->pPrivProt->bEnable = TRUE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(PrivacyProtectionEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -startPrivProt &"), _)) - .Times(1) .WillOnce(Return(0)); if ((file = fopen(fname, "r"))) { @@ -523,16 +434,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, ccsp_stop_privacy_protection) { g_pAdvSecAgent->pPrivProt->bEnable = FALSE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(PrivacyProtectionEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -stopPrivProt &"), _)) - .Times(1) .WillOnce(Return(0)); if ((file = fopen(fname, "r"))) @@ -573,16 +480,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvSecInit_Success) g_pAdvSecAgent->bEnable = TRUE; EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -enable &"), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(DeviceFingerPrintEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); @@ -602,16 +505,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvSecDeInit_Success) g_pAdvSecAgent->bEnable = FALSE; EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -disable &"), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(DeviceFingerPrintEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvSecDeInit(); @@ -636,16 +535,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaStartAdvParentalControl_Success) g_pAdvSecAgent->pAdvPC->bEnable = TRUE; EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -startAdvPC &"), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvParentalControl), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); if ((file = fopen(fname, "r"))) @@ -692,16 +587,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaStopAdvParentalControl_Success) g_pAdvSecAgent->pAdvPC->bEnable = FALSE; EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -stopAdvPC &"), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvParentalControl), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); if ((file = fopen(fname, "r"))) @@ -770,7 +661,6 @@ TEST_F(CcspAdvSecurityInternalTestFixture, advsec_webconfig_handle_blob_fingerpr g_pAdvSecAgent->pPrivProt->bEnable = TRUE; EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -enable &"),_)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(_, _)) .Times(5) @@ -851,7 +741,6 @@ TEST_F(CcspAdvSecurityInternalTestFixture, advsec_webconfig_handle_blob_fingerpr g_pAdvSecAgent->pPrivProt->bEnable = TRUE; EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -disable &"),_)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(_, _)) .Times(5) @@ -932,7 +821,6 @@ TEST_F(CcspAdvSecurityInternalTestFixture, advsec_webconfig_handle_blob_configur g_pAdvSecAgent->pPrivProt->bEnable = TRUE; EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -configure_features &"),_)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(_, _)) .Times(4) @@ -997,13 +885,10 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvSecSetLoggingPeriod) ULONG value = ADVSEC_DEFAULT_LOG_TIMEOUT; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(DeviceFingerPrintLogginPeriod), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvSecSetLoggingPeriod(value); @@ -1034,16 +919,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvSecSetLogLevel) ULONG value = 2; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(DeviceFingerPrintLogLevel), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -agentloglevel 2 &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvSecSetLogLevel(value); @@ -1096,16 +977,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvSecSetLookupTimeout) g_pAdvSecAgent->pAdvSec->pSafeBrows->bEnable = TRUE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvSecurityLookupTimeout), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -start sb null &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvSecSetLookupTimeout(value); @@ -1125,10 +1002,8 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvSecSetCustomURL) char pString[] = "https://www.google.com"; EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvSecCustomEndpointURL), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvSecSetCustomURL(pString); @@ -1143,7 +1018,6 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvSecGetCustomURL) ULONG ulSize = 20; EXPECT_CALL(*g_safecLibMock, _strcpy_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_get(_, StrEq(AdvSecCustomEndpointURL), _, _)) .WillOnce(DoAll( @@ -1169,13 +1043,10 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaRabidSetMemoryLimit) ULONG value = 100; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(RabidMemoryLimit), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaRabidSetMemoryLimit(NULL, value); @@ -1189,13 +1060,10 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaRabidSetMacCacheSize) ULONG value = 100; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(RabidMacCacheSize), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaRabidSetMacCacheSize(NULL, value); @@ -1209,13 +1077,10 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaRabidSetDNSCacheSize) ULONG value = 100; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(RabidDNSCacheSize), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaRabidSetDNSCacheSize(NULL, value); @@ -1240,13 +1105,10 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvPCInit) g_pAdvSecAgent->pAdvPC_RFC->bEnable = TRUE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvParentalControlRFCEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); if ((file = fopen(fname, "r"))) @@ -1266,7 +1128,6 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvPCInit) g_pAdvSecAgent->pAdvPC->bEnable = TRUE; EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -startAdvPC &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status1 = CosaStartAdvParentalControl(FALSE); @@ -1275,7 +1136,6 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvPCInit) EXPECT_EQ(TRUE, g_pAdvSecAgent->pAdvPC->bEnable); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -startAdvPC &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status2 = CosaAdvPCInit(NULL); @@ -1314,13 +1174,10 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvPCDeInit) g_pAdvSecAgent->pAdvPC_RFC->bEnable = FALSE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvParentalControlRFCEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); if ((file = fopen(fname, "r"))) @@ -1340,7 +1197,6 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvPCDeInit) g_pAdvSecAgent->pAdvPC->bEnable = FALSE; EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -stopAdvPC &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status1 = CosaStopAdvParentalControl(FALSE); @@ -1380,16 +1236,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvDFIcmpv6Init) g_pAdvSecAgent->pDFIcmpv6_RFC->bEnable = TRUE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(DeviceFingerPrintICMPv6Enabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -enableICMP6 &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvDFIcmpv6Init(NULL); @@ -1413,16 +1265,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvDFIcmpv6DeInit) g_pAdvSecAgent->pDFIcmpv6_RFC->bEnable = FALSE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(DeviceFingerPrintICMPv6Enabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -disableICMP6 &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvDFIcmpv6DeInit(NULL); @@ -1446,16 +1294,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaWSDisInit) g_pAdvSecAgent->pWSDiscoveryAnalysis_RFC->bEnable = TRUE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(WSDiscoveryAnalysisEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -enableWSDiscovery &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaWSDisInit(NULL); @@ -1479,16 +1323,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaWSDisDeInit) g_pAdvSecAgent->pWSDiscoveryAnalysis_RFC->bEnable = FALSE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(WSDiscoveryAnalysisEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -disableWSDiscovery &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaWSDisDeInit(NULL); @@ -1512,16 +1352,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvSecOTMInit) g_pAdvSecAgent->pAdvSecOTM_RFC->bEnable = TRUE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvSecOTMEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -enableOTM &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvSecOTMInit(NULL); @@ -1545,16 +1381,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvSecOTMDeInit) g_pAdvSecAgent->pAdvSecOTM_RFC->bEnable = FALSE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvSecOTMEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -disableOTM &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvSecOTMDeInit(NULL); @@ -1578,16 +1410,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvSecUserSpaceInit) g_pAdvSecAgent->pAdvSecUserSpace_RFC->bEnable = TRUE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvSecUserSpaceEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -enableUS &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvSecUserSpaceInit(NULL); @@ -1612,16 +1440,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvSecUserSpaceDeInit) g_pAdvSecAgent->pAdvSecUserSpace_RFC->bEnable = FALSE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvSecUserSpaceEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -disableUS &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvSecUserSpaceDeInit(NULL); @@ -1646,16 +1470,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvSecAgentInit) g_pAdvSecAgent->pAdvSecAgent_RFC->bEnable = TRUE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvSecAgentEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -enableAGT &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvSecAgentInit(NULL); @@ -1680,16 +1500,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvSecAgentDeInit) g_pAdvSecAgent->pAdvSecAgent_RFC->bEnable = FALSE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvSecAgentEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -disableAGT &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvSecAgentDeInit(NULL); @@ -1713,16 +1529,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvSecSafeBrowsingInit) g_pAdvSecAgent->pAdvSecSafeBrowsing_RFC->bEnable = TRUE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvSecSafeBrowsingEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -enableSBRule &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvSecSafeBrowsingInit(NULL); @@ -1746,16 +1558,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvSecSafeBrowsingDeInit) g_pAdvSecAgent->pAdvSecSafeBrowsing_RFC->bEnable = FALSE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvSecSafeBrowsingEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -disableSBRule &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvSecSafeBrowsingDeInit(NULL); @@ -1779,16 +1587,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvSecCujoTelemetryWiFiFPInit) g_pAdvSecAgent->pAdvSecCujoTelemetryWiFiFP_RFC->bEnable = TRUE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvSecCujoTelemetryWiFiFPEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -enableCTW &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvSecCujoTelemetryWiFiFPInit(NULL); @@ -1812,16 +1616,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvSecCujoTelemetryWiFiFPDeInit) g_pAdvSecAgent->pAdvSecCujoTelemetryWiFiFP_RFC->bEnable = FALSE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvSecCujoTelemetryWiFiFPEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -disableCTW &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvSecCujoTelemetryWiFiFPDeInit(NULL); @@ -1845,16 +1645,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvSecCujoTracerInit) g_pAdvSecAgent->pAdvSecCujoTracer_RFC->bEnable = TRUE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvSecCujoTracerEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -enableCT &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvSecCujoTracerInit(NULL); @@ -1878,16 +1674,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvSecCujoTracerDeInit) g_pAdvSecAgent->pAdvSecCujoTracer_RFC->bEnable = FALSE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvSecCujoTracerEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -disableCT &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvSecCujoTracerDeInit(NULL); @@ -1911,16 +1703,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvSecCujoTelemetryInit) g_pAdvSecAgent->pAdvSecCujoTelemetry_RFC->bEnable = TRUE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvSecCujoTelemetryEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -enableCTD &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvSecCujoTelemetryInit(NULL); @@ -1944,16 +1732,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvSecCujoTelemetryDeInit) g_pAdvSecAgent->pAdvSecCujoTelemetry_RFC->bEnable = FALSE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(AdvSecCujoTelemetryEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -disableCTD &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvSecCujoTelemetryDeInit(NULL); @@ -1977,16 +1761,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvSecAgentRaptrInit) g_pAdvSecAgent->pRaptr_RFC->bEnable = TRUE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(RaptrEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -enableRaptr &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvSecAgentRaptrInit(NULL); @@ -2010,16 +1790,12 @@ TEST_F(CcspAdvSecurityInternalTestFixture, CosaAdvSecAgentRaptrDeInit) g_pAdvSecAgent->pRaptr_RFC->bEnable = FALSE; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(RaptrEnabled), _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -disableRaptr &"), _)) - .Times(1) .WillOnce(Return(0)); ANSC_STATUS status = CosaAdvSecAgentRaptrDeInit(NULL); diff --git a/source/test/CcspAdvSecurityDmlTest/CcspAdvSecurityMock.h b/source/test/CcspAdvSecurityDmlTest/CcspAdvSecurityMock.h index f73fbf9..bd3b100 100644 --- a/source/test/CcspAdvSecurityDmlTest/CcspAdvSecurityMock.h +++ b/source/test/CcspAdvSecurityDmlTest/CcspAdvSecurityMock.h @@ -87,4 +87,211 @@ static async_id_t async_id[4]; enum {SYS_EVENT_ERROR=-1, SYS_EVENT_OK, SYS_EVENT_TIMEOUT, SYS_EVENT_HANDLE_EXIT, SYS_EVENT_RECEIVED=0x10}; +/* + * Common base test fixture shared by DML, Internal, and WebConfig test suites. + * Centralises mock object lifecycle to eliminate duplicated SetUp/TearDown code. + */ +class CcspAdvSecurityTestBase : public ::testing::Test { +protected: + void SetUp() override { + g_syscfgMock = new SyscfgMock(); + g_securewrapperMock = new SecureWrapperMock(); + g_msgpackMock = new msgpackMock(); + g_usertimeMock = new UserTimeMock(); + g_safecLibMock = new SafecLibMock(); + g_anscMemoryMock = new AnscMemoryMock(); + g_baseapiMock = new BaseAPIMock(); + g_traceMock = new TraceMock(); + g_base64Mock = new base64Mock(); + g_rbusMock = new rbusMock(); + g_cmHALMock = new CmHalMock(); + g_platformHALMock = new PlatformHalMock(); + g_cjsonMock = new cjsonMock(); + g_syseventMock = new SyseventMock(); + g_webconfigFwMock = new webconfigFwMock(); + g_anscWrapperApiMock = new AnscWrapperApiMock(); + } + + void TearDown() override { + delete g_syscfgMock; + delete g_securewrapperMock; + delete g_msgpackMock; + delete g_usertimeMock; + delete g_safecLibMock; + delete g_anscMemoryMock; + delete g_baseapiMock; + delete g_traceMock; + delete g_base64Mock; + delete g_rbusMock; + delete g_cmHALMock; + delete g_platformHALMock; + delete g_cjsonMock; + delete g_syseventMock; + delete g_webconfigFwMock; + delete g_anscWrapperApiMock; + g_syscfgMock = nullptr; + g_securewrapperMock = nullptr; + g_msgpackMock = nullptr; + g_usertimeMock = nullptr; + g_safecLibMock = nullptr; + g_anscMemoryMock = nullptr; + g_baseapiMock = nullptr; + g_traceMock = nullptr; + g_base64Mock = nullptr; + g_rbusMock = nullptr; + g_cmHALMock = nullptr; + g_platformHALMock = nullptr; + g_cjsonMock = nullptr; + g_syseventMock = nullptr; + g_webconfigFwMock = nullptr; + g_anscWrapperApiMock = nullptr; + } + + /* --- Data model allocation helpers --- */ + + PCOSA_DATAMODEL_AGENT CreateAgent(BOOL bEnable = TRUE) { + PCOSA_DATAMODEL_AGENT p = (PCOSA_DATAMODEL_AGENT)calloc(1, sizeof(COSA_DATAMODEL_AGENT)); + EXPECT_NE(p, nullptr); + p->bEnable = bEnable; + g_pAdvSecAgent = p; + return p; + } + + void CreateAdvSec() { + ASSERT_NE(g_pAdvSecAgent, nullptr); + g_pAdvSecAgent->pAdvSec = (PCOSA_DATAMODEL_ADVSEC)calloc(1, sizeof(COSA_DATAMODEL_ADVSEC)); + ASSERT_NE(g_pAdvSecAgent->pAdvSec, nullptr); + } + + void CreateSafeBrowsing(BOOL bEnable = FALSE) { + ASSERT_NE(g_pAdvSecAgent, nullptr); + if (!g_pAdvSecAgent->pAdvSec) CreateAdvSec(); + g_pAdvSecAgent->pAdvSec->pSafeBrows = (PCOSA_DATAMODEL_SB)calloc(1, sizeof(COSA_DATAMODEL_SB)); + ASSERT_NE(g_pAdvSecAgent->pAdvSec->pSafeBrows, nullptr); + g_pAdvSecAgent->pAdvSec->pSafeBrows->bEnable = bEnable; + } + + void CreateSoftflowd(BOOL bEnable = FALSE) { + ASSERT_NE(g_pAdvSecAgent, nullptr); + if (!g_pAdvSecAgent->pAdvSec) CreateAdvSec(); + g_pAdvSecAgent->pAdvSec->pSoftFlowd = (PCOSA_DATAMODEL_SOFTFLOWD)calloc(1, sizeof(COSA_DATAMODEL_SOFTFLOWD)); + ASSERT_NE(g_pAdvSecAgent->pAdvSec->pSoftFlowd, nullptr); + g_pAdvSecAgent->pAdvSec->pSoftFlowd->bEnable = bEnable; + } + + void CreateParentalControl(BOOL bEnable = FALSE) { + ASSERT_NE(g_pAdvSecAgent, nullptr); + g_pAdvSecAgent->pAdvPC = (PCOSA_DATAMODEL_ADVPARENTALCONTROL)calloc(1, sizeof(COSA_DATAMODEL_ADVPARENTALCONTROL)); + ASSERT_NE(g_pAdvSecAgent->pAdvPC, nullptr); + g_pAdvSecAgent->pAdvPC->bEnable = bEnable; + } + + void CreatePrivacyProtection(BOOL bEnable = FALSE) { + ASSERT_NE(g_pAdvSecAgent, nullptr); + g_pAdvSecAgent->pPrivProt = (PCOSA_DATAMODEL_PRIVACYPROTECTION)calloc(1, sizeof(COSA_DATAMODEL_PRIVACYPROTECTION)); + ASSERT_NE(g_pAdvSecAgent->pPrivProt, nullptr); + g_pAdvSecAgent->pPrivProt->bEnable = bEnable; + } + + void CreateRabid(ULONG memLimit = 0, ULONG macCache = 0, ULONG dnsCache = 0) { + ASSERT_NE(g_pAdvSecAgent, nullptr); + g_pAdvSecAgent->pRabid = (PCOSA_DATAMODEL_RABID)calloc(1, sizeof(COSA_DATAMODEL_RABID)); + ASSERT_NE(g_pAdvSecAgent->pRabid, nullptr); + g_pAdvSecAgent->pRabid->uMemoryLimit = memLimit; + g_pAdvSecAgent->pRabid->uMacCacheSize = macCache; + g_pAdvSecAgent->pRabid->uDNSCacheSize = dnsCache; + } + + void FreeAgent() { + if (!g_pAdvSecAgent) return; + if (g_pAdvSecAgent->pAdvSec) { + free(g_pAdvSecAgent->pAdvSec->pSafeBrows); + free(g_pAdvSecAgent->pAdvSec->pSoftFlowd); + free(g_pAdvSecAgent->pAdvSec); + } + free(g_pAdvSecAgent->pAdvPC); + free(g_pAdvSecAgent->pPrivProt); + free(g_pAdvSecAgent->pRabid); + free(g_pAdvSecAgent->pAdvPC_RFC); + free(g_pAdvSecAgent->pPrivProt_RFC); + free(g_pAdvSecAgent->pDFIcmpv6_RFC); + free(g_pAdvSecAgent->pWSDiscoveryAnalysis_RFC); + free(g_pAdvSecAgent->pAdvSecOTM_RFC); + free(g_pAdvSecAgent->pAdvSecUserSpace_RFC); + free(g_pAdvSecAgent->pRaptr_RFC); + free(g_pAdvSecAgent->pAdvSecAgent_RFC); + free(g_pAdvSecAgent->pAdvSecSafeBrowsing_RFC); + free(g_pAdvSecAgent->pAdvSecCujoTelemetryWiFiFP_RFC); + free(g_pAdvSecAgent->pAdvSecCujoTracer_RFC); + free(g_pAdvSecAgent->pAdvSecCujoTelemetry_RFC); + free(g_pAdvSecAgent->pLevl_RFC); + free(g_pAdvSecAgent); + g_pAdvSecAgent = nullptr; + } + + /* --- Sentinel file helpers --- */ + + void EnsureSentinelFile(const char *path) { + FILE *f = fopen(path, "r"); + if (f) { + fclose(f); + sentinelCreated_ = false; + } else { + f = fopen(path, "w"); + if (f) fclose(f); + sentinelCreated_ = true; + } + sentinelPath_ = path; + } + + void CleanupSentinelFile() { + if (sentinelCreated_ && !sentinelPath_.empty()) { + remove(sentinelPath_.c_str()); + } + sentinelCreated_ = false; + sentinelPath_.clear(); + } + + /* --- Mock expectation helpers for common patterns --- */ + + void ExpectSyscfgSetAndCommit(const char *key, int times = 1) { + EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(StrEq(key), _)) + .Times(times) + .WillRepeatedly(Return(0)); + EXPECT_CALL(*g_syscfgMock, syscfg_commit()) + .Times(times) + .WillRepeatedly(Return(0)); + } + + void ExpectSprintfChk(int times = 1) { + EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) + .Times(times) + .WillRepeatedly(Return(0)); + } + + void ExpectScriptCall(const char *scriptSubstr) { + EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr(scriptSubstr), _)) + .Times(1) + .WillOnce(Return(0)); + } + + void ExpectStrcmpMatch(const char *expected, const char *param) { + int match = 0; + EXPECT_CALL(*g_safecLibMock, _strcmp_s_chk(StrEq(expected), strlen(expected), StrEq(param), _, _, _)) + .Times(1) + .WillOnce(DoAll(SetArgPointee<3>(match), Return(EOK))); + } + + void ExpectStrcmpMismatch(const char *expected, const char *param) { + int mismatch = 1; + EXPECT_CALL(*g_safecLibMock, _strcmp_s_chk(StrEq(expected), strlen(expected), StrEq(param), _, _, _)) + .Times(1) + .WillOnce(DoAll(SetArgPointee<3>(mismatch), Return(EOK))); + } + +private: + bool sentinelCreated_ = false; + std::string sentinelPath_; +}; + #endif // CCSP_ADV_SECURITY_MOCK_H diff --git a/source/test/CcspAdvSecurityDmlTest/CcspAdvSecurityWebconfigTest.cpp b/source/test/CcspAdvSecurityDmlTest/CcspAdvSecurityWebconfigTest.cpp index 12027d6..7f822dd 100644 --- a/source/test/CcspAdvSecurityDmlTest/CcspAdvSecurityWebconfigTest.cpp +++ b/source/test/CcspAdvSecurityDmlTest/CcspAdvSecurityWebconfigTest.cpp @@ -18,61 +18,7 @@ #include "CcspAdvSecurityMock.h" -class CcspAdvSecurityWebconfigTestFixture : public ::testing::Test { -protected: - void SetUp() override { - g_syscfgMock = new SyscfgMock(); - g_securewrapperMock = new SecureWrapperMock(); - g_msgpackMock = new msgpackMock(); - g_usertimeMock = new UserTimeMock(); - g_safecLibMock = new SafecLibMock(); - g_anscMemoryMock = new AnscMemoryMock(); - g_baseapiMock = new BaseAPIMock(); - g_traceMock = new TraceMock(); - g_base64Mock = new base64Mock(); - g_rbusMock = new rbusMock(); - g_cmHALMock = new CmHalMock(); - g_platformHALMock = new PlatformHalMock(); - g_cjsonMock = new cjsonMock(); - g_syseventMock = new SyseventMock(); - g_webconfigFwMock = new webconfigFwMock(); - g_anscWrapperApiMock = new AnscWrapperApiMock(); - } - - void TearDown() override { - delete g_syscfgMock; - delete g_securewrapperMock; - delete g_msgpackMock; - delete g_usertimeMock; - delete g_safecLibMock; - delete g_anscMemoryMock; - delete g_baseapiMock; - delete g_traceMock; - delete g_base64Mock; - delete g_rbusMock; - delete g_cmHALMock; - delete g_platformHALMock; - delete g_cjsonMock; - delete g_syseventMock; - delete g_webconfigFwMock; - delete g_anscWrapperApiMock; - g_syscfgMock = nullptr; - g_securewrapperMock = nullptr; - g_msgpackMock = nullptr; - g_usertimeMock = nullptr; - g_safecLibMock = nullptr; - g_anscMemoryMock = nullptr; - g_baseapiMock = nullptr; - g_traceMock = nullptr; - g_base64Mock = nullptr; - g_rbusMock = nullptr; - g_cmHALMock = nullptr; - g_platformHALMock = nullptr; - g_cjsonMock = nullptr; - g_syseventMock = nullptr; - g_webconfigFwMock = nullptr; - g_anscWrapperApiMock = nullptr; - } +class CcspAdvSecurityWebconfigTestFixture : public CcspAdvSecurityTestBase { }; // cosa_adv_security_webconfig.c file test cases @@ -82,7 +28,6 @@ TEST_F(CcspAdvSecurityWebconfigTestFixture, advsec_webconfig_get_blobversion_suc char subdoc[] = "test"; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_get(_, _, _, _)) @@ -102,7 +47,6 @@ TEST_F(CcspAdvSecurityWebconfigTestFixture, advsec_webconfig_get_blobversion_fai char subdoc[] = "test"; EXPECT_CALL(*g_safecLibMock, _sprintf_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_get(_, _, _, _)) .WillOnce(DoAll( @@ -126,11 +70,9 @@ TEST_F(CcspAdvSecurityWebconfigTestFixture, advsec_webconfig_set_blobversion_suc .WillRepeatedly(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(_, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_commit()) - .Times(1) .WillOnce(Return(0)); int result = advsec_webconfig_set_blobversion(subdoc, version); @@ -149,7 +91,6 @@ TEST_F(CcspAdvSecurityWebconfigTestFixture, advsec_webconfig_set_blobversion_fai .WillRepeatedly(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(_, _)) - .Times(1) .WillOnce(Return(1)); int result = advsec_webconfig_set_blobversion(subdoc, version); @@ -162,10 +103,8 @@ TEST_F(CcspAdvSecurityWebconfigTestFixture, advsec_webconfig_init) { blobRegInfo *blobData; EXPECT_CALL(*g_safecLibMock, _memset_s_chk(_, _, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_safecLibMock, _strcpy_s_chk(_, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_webconfigFwMock, register_sub_docs(_, _, _, _)) @@ -211,13 +150,10 @@ TEST_F(CcspAdvSecurityWebconfigTestFixture, advsec_webconfig_process_request_suc g_pAdvSecAgent->pPrivProt->bEnable = TRUE; EXPECT_CALL(*g_safecLibMock, _memset_s_chk(_, _, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_safecLibMock, _strcmp_s_chk(_, _, _, _, _, _)) - .Times(1) .WillOnce(DoAll(SetArgPointee<3>(comparisonResult), Return(EOK))); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -configure_features &"),_)) - .Times(1) .WillOnce(Return(0)); int result = advsec_webconfig_handle_blob(advsec.param); @@ -269,13 +205,10 @@ TEST_F(CcspAdvSecurityWebconfigTestFixture, advsec_webconfig_process_request_fai g_pAdvSecAgent->pPrivProt->bEnable = TRUE; EXPECT_CALL(*g_safecLibMock, _memset_s_chk(_, _, _, _, _)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_safecLibMock, _strcmp_s_chk(_, _, _, _, _, _)) - .Times(1) .WillOnce(DoAll(SetArgPointee<3>(comparisonResult), Return(EOK))); EXPECT_CALL(*g_securewrapperMock, v_secure_system(HasSubstr("/usr/ccsp/advsec/start_adv_security.sh -disable &"),_)) - .Times(1) .WillOnce(Return(0)); EXPECT_CALL(*g_syscfgMock, syscfg_set_nns(_, _))