Skip to content

removed read modify write from ringbuffer #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raphael-s-steiner merged 1 commit into from
Apr 2, 2026
Merged

removed read modify write from ringbuffer #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions include/RingBuffer/RingBuffer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ class alignas(CACHE_LINE_SIZE) RingBuffer {
inline std::size_t getTailPosition() const noexcept;
inline std::size_t getHeadPosition() const noexcept;

inline void advanceTail(const std::size_t n = 1U) noexcept;
inline void advanceHead(const std::size_t n = 1U) noexcept;
inline void updateTail(const std::size_t n) noexcept;
inline void updateHead(const std::size_t n) noexcept;

public:
inline constexpr std::size_t capacity() const noexcept;
Expand Down Expand Up @@ -106,13 +106,13 @@ inline std::size_t RingBuffer<T, N>::getHeadPosition() const noexcept {
};

template <typename T, std::size_t N>
inline void RingBuffer<T, N>::advanceTail(const std::size_t n) noexcept {
tailCounter_.fetch_add(n, std::memory_order_release);
inline void RingBuffer<T, N>::updateTail(const std::size_t n) noexcept {
tailCounter_.store(n, std::memory_order_release);
};

template <typename T, std::size_t N>
inline void RingBuffer<T, N>::advanceHead(const std::size_t n) noexcept {
headCounter_.fetch_add(n, std::memory_order_release);
inline void RingBuffer<T, N>::updateHead(const std::size_t n) noexcept {
headCounter_.store(n, std::memory_order_release);
};

/**
Expand Down Expand Up @@ -161,7 +161,7 @@ inline std::optional<T> RingBuffer<T, N>::pop() noexcept {
|| ((cachedHeadCounter_ = headCounter_.load(std::memory_order_acquire)) != tail)) {
const std::size_t pos = tail % N;
std::optional<T> val(data_[pos]);
advanceTail();
updateTail(tail + 1U);
return val;
} else {
return std::optional<T>(std::nullopt);
Expand All @@ -176,7 +176,7 @@ inline bool RingBuffer<T, N>::pop(T &out) noexcept {
if (hasData) {
const std::size_t pos = tail % N;
out = data_[pos];
advanceTail();
updateTail(tail + 1U);
}
return hasData;
}
Expand All @@ -190,7 +190,7 @@ inline bool RingBuffer<T, N>::push(const T value) noexcept {
|| ((cachedTailCounter_ = tailCounter_.load(std::memory_order_acquire)) != headLoopAround);
if (nonFull) {
data_[head % N] = value;
advanceHead();
updateHead(head + 1U);
}
return nonFull;
}
Expand Down Expand Up @@ -226,7 +226,7 @@ inline bool RingBuffer<T, N>::push(InputIt first, InputIt last) noexcept {
std::advance(first, numElementsFirstPush);
std::copy_n(std::execution::unseq, first, numElementsSecondPush, data_.begin());

advanceHead(numElements);
updateHead(head + numElements);
}
return enoughSpace;
}
Expand Down