[No issue] From function to view, and behiond

[wiwwo]

Hi!
First of all, SUPER work, RESPECT! :-)

Being a Security sensitive DBA, what I did was take your .sql, get rid of the create function (and related) parts , and just use it as an concatenation of select statements, with union all. Took me literally 10 seconds to do.

As from subject, this is not an issue, but a more paranoid people friendly opportunity.

Keep up the great work!!!
Cheers

[pgr0ss]

Do you mind showing your modified version? Either directly here or as a gist? Thanks!

[wiwwo]

Sure!
Here you go, easy to diff

pgFirstAid_asSelect.sql

[randoneering]

Hey @wiwwo - maybe I am thick in the head or I am not reading this correctly, but are you stating that this is a concern that you can just run these all as one query?

[wiwwo]

Hi @randoneering

is a concern that you can just run these all as one query?
TL;DR:
Not really. What I actually wrote is a single query. The problem is giving the user the create function privilege.

The "original" file does not run a query; it creates a procedure, that than can be selected from.

Which means, the user running the script should have at least "monitoring" privileges, AND privileges to create functions (in this case, in the public schema).
This last part, the create function is something I don't normally give to those kind of users; and regardless of my personal choices, this grant can be avoided by just running the query directly instead of declaring the function.