Refs #406: Accept full issue URL bounty references#494
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds strict issue-number boundaries and full GitHub issue URL parsing to bounty-reference extraction in queue-health and submission-quality pipelines, threads an optional repo filter through extraction and PR-matching, and updates error messages and live-load payloads to include repo-aware behavior. ChangesBounty reference extraction with repo-scoped GitHub issue URL support
Possibly related PRs
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
GHX5T-SOL
left a comment
GHX5T-SOL
left a comment
There was a problem hiding this comment.
Reviewed current head 0d25261247710692f530989082bf4e227293675a as a non-author.
Requesting changes because the new full GitHub issue URL path is not equivalent to the existing Refs #<issue> path in duplicate detection. _title_from_submission() skips lines containing BOUNTY_REF_RE, but it does not skip a line that is only a full issue URL. When a submission starts with the new supported format, the URL becomes the extracted submission title, so _similar_open_prs() compares the open PR title against the URL and misses the duplicate/similar-work warning.
Local repro on this head:
/tmp/gitted-bin/uv run --extra dev python -c 'from scripts.submission_quality_gate import evaluate_submission; data={"repo":"ramimbo/mergework","submission_text":"https://github.com/ramimbo/mergework/issues/319\n\nHarden the bounty submission checks\n\nValidation: pytest passed.","bounties":[{"number":319,"state":"OPEN","awards_remaining":1}],"pull_requests":[{"number":12,"title":"Harden the bounty submission checks","body":"Refs #319","state":"OPEN","url":"https://github.com/ramimbo/mergework/pull/12"}]}; result=evaluate_submission(data); print(result["bounty_reference"]); print(result["similar_open_prs"])'Output:
319
[]
The equivalent first-line shorthand still finds the similar open PR:
Refs #319 -> [{'number': 12, 'title': 'Harden the bounty submission checks', 'url': 'https://github.com/ramimbo/mergework/pull/12'}]
Impact: the PR fixes the primary bounty-reference check, but a common copy-paste style for full URLs can bypass the gate that warns agents about already-open similar work on the same bounty. A targeted fix would make _title_from_submission() ignore GITHUB_ISSUE_URL_RE-only lines, matching the existing shorthand behavior, and add a regression where the full issue URL appears before the human title.
Validation I ran:
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 /tmp/gitted-bin/uv run --extra dev python -m pytest tests/test_submission_quality_gate.py tests/test_pr_queue_health.py -q->35 passed.PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 /tmp/gitted-bin/uv run --extra dev python -m pytest -q->417 passed./tmp/gitted-bin/uv run --extra dev ruff check .-> passed./tmp/gitted-bin/uv run --extra dev ruff format --check .->79 files already formatted./tmp/gitted-bin/uv run --extra dev python scripts/docs_smoke.py->docs smoke ok./tmp/gitted-bin/uv run --extra dev python -m mypy app-> success.git diff --check upstream/main...HEAD-> clean.git diff --no-ext-diff upstream/main..HEAD | gitleaks stdin --no-banner --redact --exit-code 1-> no leaks found.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 321652fe-db26-44fc-8efd-875389324635
📒 Files selected for processing (4)
scripts/pr_queue_health.pyscripts/submission_quality_gate.pytests/test_pr_queue_health.pytests/test_submission_quality_gate.py
jtc268
left a comment
jtc268
left a comment
There was a problem hiding this comment.
Reviewed current head 0d25261247710692f530989082bf4e227293675a.
I found a separate fallback-path issue from the existing duplicate-title finding. The PR correctly threads repo through normal live-context paths, but _load_live_context() drops repo in the GitHub-load exception return. That means when gh is unavailable or times out, evaluate_submission() receives no repo context and _bounty_refs() stops filtering full issue URLs to the target repo. A foreign issue URL can then pass the bounty-reference check as if it belonged to ramimbo/mergework.
Local repro on this head:
import scripts.submission_quality_gate as gate
def fail(args):
raise RuntimeError("simulated gh outage")
gate._run_gh_json = fail
ctx = gate._load_live_context(
"ramimbo/mergework",
"https://github.com/other/repo/issues/123
Summary: test
Validation: pytest passed",
"https://api.mrwk.ltclab.site",
)
result = gate.evaluate_submission(ctx)
print(ctx)
print(result["bounty_reference"])
print(result["checks"][0])Observed output includes no repo in ctx, then bounty_reference becomes 123 and the first check is PASS bounty_reference: found bounty reference #123. Expected behavior is to keep the target repo in the fallback context so foreign GitHub issue URLs remain ignored and the submission fails the missing-reference check.
Suggested fix: add "repo": repo to the exception return from _load_live_context() and add a regression covering a foreign full issue URL under simulated GitHub-load failure.
Validation on this head:
uv run --extra dev python -m pytest tests/test_submission_quality_gate.py tests/test_pr_queue_health.py -q-> 35 passeduv run --extra dev python scripts/docs_smoke.py-> docs smoke okgit diff --check origin/main...HEAD-> clean
|
Addressed the review feedback in Changes:
Validation rerun:
|
GHX5T-SOL
left a comment
GHX5T-SOL
left a comment
There was a problem hiding this comment.
Reviewed current head 755939baf836de3b632f37d71d111b3c9a3619d4 as a follow-up to my earlier changes-requested review on 0d25261247710692f530989082bf4e227293675a.
The update resolves my blocker: _title_from_submission() now skips full GitHub issue URL lines, so a URL-first submission still compares the real title against open PR titles. I also checked the separate fallback-path issue raised by another reviewer: _load_live_context() now preserves repo when GitHub loading fails, so foreign full issue URLs remain filtered.
Local verification:
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python -m pytest tests/test_submission_quality_gate.py tests/test_pr_queue_health.py -q->37 passed- URL-first duplicate repro now returns the similar open PR instead of
[] - simulated
ghoutage withhttps://github.com/other/project/issues/319now keepsrepo=ramimbo/mergeworkand fails the bounty-reference check PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python -m pytest -q->419 passedPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python scripts/docs_smoke.py->docs smoke ok- Ruff check/format on changed files -> passed / already formatted
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python -m mypy app-> successgit diff --check origin/main...HEAD-> clean- diff-only Gitleaks -> no leaks found
GitHub readback shows PR #494 is open, non-draft, CLEAN, with successful CI and CodeRabbit checks. No further blockers from my review.
INDICUMA
left a comment
INDICUMA
left a comment
There was a problem hiding this comment.
Reviewed current head 755939baf836de3b632f37d71d111b3c9a3619d4 as a non-author.
I checked the repo-scoped full GitHub issue URL handling across both affected tools. The current head now keeps shorthand references and same-repo full issue URLs aligned, filters foreign issue URLs when repo is known, preserves repo through _load_live_context() fallback paths, and keeps duplicate/similar-open-PR detection working when the submission starts with a full issue URL before the human title.
Independent verification:
./.venv312/bin/python -m pytest tests/test_submission_quality_gate.py tests/test_pr_queue_health.py -q->37 passed- URL-first submission repro now returns the similar open PR instead of
[] - simulated
ghoutage withhttps://github.com/other/project/issues/319keepsrepo=ramimbo/mergework, leavesbounty_referenceasNone, and fails the bounty-reference check as expected ./.venv312/bin/python -m pytest -q->419 passed./.venv312/bin/python -m ruff check scripts/submission_quality_gate.py scripts/pr_queue_health.py tests/test_submission_quality_gate.py tests/test_pr_queue_health.py-> passed./.venv312/bin/python -m ruff format --check scripts/submission_quality_gate.py scripts/pr_queue_health.py tests/test_submission_quality_gate.py tests/test_pr_queue_health.py->4 files already formatted./.venv312/bin/python -m mypy app scripts/submission_quality_gate.py scripts/pr_queue_health.py-> success./.venv312/bin/python scripts/docs_smoke.py->docs smoke okgit diff --check origin/main...HEAD-> clean
I do not see further blockers on the current head. No secrets, wallet material, private data, production mutation, price/exchange/liquidity claim, or off-ramp claim was used.
4 participants
Summary
Bounty #406 small fix.
This aligns the pre-submission tools with the webhook payout path by accepting full GitHub issue URLs such as
https://github.com/ramimbo/mergework/issues/406as bounty references. The webhook already recognizes same-repo full issue URLs, butscripts/submission_quality_gate.pyandscripts/pr_queue_health.pyonly recognized shorthand forms such asRefs #406.What Changed
submission_quality_gate.pywhile preserving existingBounty #<issue>,Refs #<issue>, and/claim #<issue>behavior.pr_queue_health.pyso live queue reports do not falsely flag PRs that link the bounty with a full same-repo issue URL.Evidence
Without this, a PR body that links
https://github.com/ramimbo/mergework/issues/406can be payable through the webhook path but fail or be flagged by the agent-facing preflight scripts as missing a bounty reference.Validation
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python -m pytest tests/test_submission_quality_gate.py tests/test_pr_queue_health.py -q-> 35 passedPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev ruff check scripts/submission_quality_gate.py scripts/pr_queue_health.py tests/test_submission_quality_gate.py tests/test_pr_queue_health.py-> passedPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev ruff format --check scripts/submission_quality_gate.py scripts/pr_queue_health.py tests/test_submission_quality_gate.py tests/test_pr_queue_health.py-> passedPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python -m mypy scripts/submission_quality_gate.py scripts/pr_queue_health.py-> passedPYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --extra dev python -m pytest -q-> 417 passedgit diff --check-> passedSummary by CodeRabbit
New Features
Bug Fixes
Tests