db:migrate doesn't reload migration files

[amalagaura]

After fat fingering a migration file
PG::Error: ERROR: type "stringa" does not exist

I fix the migration, but rake "db:migrate" does not pick up the new corrected file, if running the command again it will either say:

** Invoke db:migrate => "Completed"

or throw the same exception again. I try reload! but it does not help.

[markrebec]

Any chance your migration failed in a way that it did not roll itself back? Take a look at your db schema and version to see if part of the migration was run but not rolled back on failure. You might also want to try running db:rollback then db:migrate again.

[amalagaura]

It was completely rolled back. I am using postgres which does the rollback, in addition it was a single line.

Running rake db:migrate from the command line lets it run. I thought this may be a known issue.

[markrebec]

Thought I'd make sure to eliminate the obvious :) Sounds like it's definitely a bug, though, and sounds like your assumption is correct that the migration file was not reloaded (I also don't think reload! would reload migrations either, but I'm not sure). Do you know if quitting and re-launching the console, then running the migration works (I'd assume yes, since everything is reloaded)? That of course is not a solution, but might help prove the source of the issue.

[amalagaura]

Running the migration after relaunching console does work.

I looked through the code and this bug makes sense since this gem does not deal with the reload! command.

[markrebec]

I wonder if it's worth adding a new reload command that would wrap the rails built-in reload! and reload migrations, tests (since I don't think they're reloaded by reload! either), etc. Might be possible to even just use alias_method_chain...?

I think, though, that tests might already be handled by commands and be reloaded automatically, but I'm not sure. If that is the case, maybe migrations (and anything else we come across) can be reloaded at the same time?