From 6d4eb2bc8bac0ab8ed79f380765f181bf23785ba Mon Sep 17 00:00:00 2001 From: Dmitry Baryshkov Date: Wed, 4 Mar 2026 15:34:48 +0200 Subject: [PATCH] FROMLIST: drm/msm: restore GEM-related IOCTLs for KMS devices The MSM GBM backend uses MSM_GEM_NEW to allocate GEM buffers from the KMS driver, imports them into the GPU driver (msm or kgsl) and then uses them for rendering / blending. Commit 98f11fd1cf92 ("drm/msm: Take the ioctls away from the KMS-only driver") dropped all IOCTLs from the MSM KMS devices, pointing out the need to use dumb buffers, however dumb buffers should not be used by the GPU for rendering. Restore GEM-related IOCTLs for the KMS devices. Fixes: 98f11fd1cf92 ("drm/msm: Take the ioctls away from the KMS-only driver") Signed-off-by: Dmitry Baryshkov Link: https://lore.kernel.org/all/20260304-msm-restore-ioctls-v1-1-b28f9231fcd2@oss.qualcomm.com/ Signed-off-by: Yash Gupta --- drivers/gpu/drm/msm/msm_drv.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c index 7e977fec41007..5d3297c671871 100644 --- a/drivers/gpu/drm/msm/msm_drv.c +++ b/drivers/gpu/drm/msm/msm_drv.c @@ -797,6 +797,14 @@ static const struct drm_ioctl_desc msm_ioctls[] = { DRM_IOCTL_DEF_DRV(MSM_VM_BIND, msm_ioctl_vm_bind, DRM_RENDER_ALLOW), }; +static const struct drm_ioctl_desc msm_kms_ioctls[] = { + DRM_IOCTL_DEF_DRV(MSM_GEM_NEW, msm_ioctl_gem_new, DRM_RENDER_ALLOW), + DRM_IOCTL_DEF_DRV(MSM_GEM_INFO, msm_ioctl_gem_info, DRM_RENDER_ALLOW), + DRM_IOCTL_DEF_DRV(MSM_GEM_CPU_PREP, msm_ioctl_gem_cpu_prep, DRM_RENDER_ALLOW), + DRM_IOCTL_DEF_DRV(MSM_GEM_CPU_FINI, msm_ioctl_gem_cpu_fini, DRM_RENDER_ALLOW), + DRM_IOCTL_DEF_DRV(MSM_GEM_MADVISE, msm_ioctl_gem_madvise, DRM_RENDER_ALLOW), +}; + static void msm_show_fdinfo(struct drm_printer *p, struct drm_file *file) { struct drm_device *dev = file->minor->dev; @@ -866,6 +874,8 @@ static const struct drm_driver msm_kms_driver = { #endif MSM_FBDEV_DRIVER_OPS, .show_fdinfo = msm_show_fdinfo, + .ioctls = msm_kms_ioctls, + .num_ioctls = ARRAY_SIZE(msm_kms_ioctls), .fops = &fops, .name = "msm-kms", .desc = "MSM Snapdragon DRM",