Skip to content

[Bug] Partial editing of sample metadata possible although invalid information present #1401

@KochTobi

Description

@KochTobi

What actually happened?

Following the steps necessary for sample registriation:
On the Register Sample Batch page inside an experiment, I performed the following steps

  1. Click on Edit for a batch
  2. Download the XLSX file
  3. Remove a species, specimen or analyte or other required information (by pressing DEL when the cell is selected)
  4. Upload the modified XLSX file
  5. Observe validation failing in the dialog (errors are shown e.g. missing species)
  6. Confirm the dialog by clicking the button
  7. The dialog closes and registration is triggered
  8. You are shown a success toast

What did you expect to happen?

I expected to be stopped in step 6. Clicking the confirm button on the dialog should not do anything when validation is not successful for all sample entries.

I excpect:

  • Given a file was uploaded, When validation is not successful, then clicking the confirm button does not trigger any action.
  • Given a file was uploaded, When validation is successful, clicking the confirm button registers all samples.

Steps to reproduce

  1. Click on Edit for a batch
  2. Download the XLSX file
  3. Remove a species, specimen or analyte or other required information (by pressing DEL when the cell is selected)
  4. Upload the modified XLSX file
  5. Observe validation failing in the dialog (errors are shown e.g. missing species)
  6. Confirm the dialog by clicking the button
  7. The dialog closes and registration is triggered (this is wrong)
  8. You are shown a success toast (this is wrong)

Affected application area

Sample Management

Browser(s) where the problem occurs

Microsoft Edge, Safari, Firefox, Chrome

Additional context

A valid example file:

2026-03-20_Q2RGU6_sample-metadata-update-template.xlsx

An invalid example file:

2026-03-20_Q2RGU6_sample-metadata-update-template_invalid.xlsx

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingtriageAn issue that is in discussion to be either scheduled for implepmentation or denied

    Type

    No type

    Projects

    Status

    In Progress

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions