Remove needless calls to _PyThreadState_Attach/_PyThreadState_Detach.

ZeroIntensity · ZeroIntensity · commit f9cb8f7089ce · 2026-05-05T17:06:41.000-04:00
diff --git a/Python/pylifecycle.c b/Python/pylifecycle.c
@@ -2381,11 +2381,9 @@ make_pre_finalization_calls(PyThreadState *tstate, int subinterpreters)
                 break;
             }
         }
-        // Temporarily let other threads execute
-        _PyThreadState_Detach(tstate);
+
         _PyEval_StartTheWorldAll(interp->runtime);
         PyMutex_Unlock(&interp->ceval.pending.mutex);
-        _PyThreadState_Attach(tstate);
     }
     assert(PyMutex_IsLocked(&interp->ceval.pending.mutex));
     assert(_Py_atomic_load_uintptr(&interp->finalization_guards) == _PyInterpreterGuard_GUARDS_NOT_ALLOWED);

Original file line number	Diff line number	Diff line change
`@@ -2381,11 +2381,9 @@ make_pre_finalization_calls(PyThreadState *tstate, int subinterpreters)`
`2381`	`2381`	`break;`
`2382`	`2382`	`}`
`2383`	`2383`	`}`
`2384`		`- // Temporarily let other threads execute`
`2385`		`- _PyThreadState_Detach(tstate);`
	`2384`	`+`
`2386`	`2385`	`_PyEval_StartTheWorldAll(interp->runtime);`
`2387`	`2386`	`PyMutex_Unlock(&interp->ceval.pending.mutex);`
`2388`		`- _PyThreadState_Attach(tstate);`
`2389`	`2387`	`}`
`2390`	`2388`	`assert(PyMutex_IsLocked(&interp->ceval.pending.mutex));`
`2391`	`2389`	`assert(_Py_atomic_load_uintptr(&interp->finalization_guards) == _PyInterpreterGuard_GUARDS_NOT_ALLOWED);`