Skip to content

Commit c305d81

Browse files
Fix get_gc_stats after moving to generational GC
1 parent 2a1e38a commit c305d81

2 files changed

Lines changed: 3 additions & 19 deletions

File tree

Lib/test/test_get_gc_stats.py

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -112,21 +112,12 @@ def _check_gc_stats(self, before, after):
112112
self.assertGreater(after["ts_stop"], before["ts_stop"], (before, after))
113113
self.assertGreater(after["duration"], before["duration"], (before, after))
114114

115-
self.assertGreater(after["object_visits"], before["object_visits"], (before, after))
116115
self.assertGreater(after["candidates"], before["candidates"], (before, after))
117116

118117
# may not grow
119118
self.assertGreaterEqual(after["collected"], before["collected"], (before, after))
120119
self.assertGreaterEqual(after["uncollectable"], before["uncollectable"], (before, after))
121120

122-
if before["gen"] == 1:
123-
self.assertGreaterEqual(after["objects_transitively_reachable"],
124-
before["objects_transitively_reachable"],
125-
(before, after))
126-
self.assertGreaterEqual(after["objects_not_transitively_reachable"],
127-
before["objects_not_transitively_reachable"],
128-
(before, after))
129-
130121
def _check_interpreter_gc_stats(self, before_stats, after_stats):
131122
before_iids = get_interpreter_identifiers(before_stats)
132123
after_iids = get_interpreter_identifiers(after_stats)
@@ -150,11 +141,8 @@ def _check_interpreter_gc_stats(self, before_stats, after_stats):
150141
self._check_gc_stats(before, after)
151142

152143
def test_get_gc_stats_fields(self):
153-
keys = sorted(("gen", "iid", "ts_start", "ts_stop", "heap_size",
154-
"work_to_do", "collections", "object_visits",
155-
"collected", "uncollectable", "candidates",
156-
"objects_transitively_reachable",
157-
"objects_not_transitively_reachable",
144+
keys = sorted(("gen", "iid", "ts_start", "ts_stop", #"heap_size",
145+
"collections", "collected", "uncollectable", "candidates",
158146
"duration"))
159147
stats = _remote_debugging.get_gc_stats(os.getpid(), all_interpreters=False)
160148
self.assertIsInstance(stats, list)

Modules/_remote_debugging/gc_stats.h

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,15 +87,11 @@ read_gc_stats(struct gc_stats *stats, int64_t iid, PyObject *result)
8787

8888
ADD_STATS_INT64(ts_start);
8989
ADD_STATS_INT64(ts_stop);
90-
ADD_STATS_SSIZE(heap_size);
91-
ADD_STATS_SSIZE(work_to_do);
90+
// ADD_STATS_SSIZE(heap_size);
9291
ADD_STATS_SSIZE(collections);
93-
ADD_STATS_SSIZE(object_visits);
9492
ADD_STATS_SSIZE(collected);
9593
ADD_STATS_SSIZE(uncollectable);
9694
ADD_STATS_SSIZE(candidates);
97-
ADD_STATS_SSIZE(objects_transitively_reachable);
98-
ADD_STATS_SSIZE(objects_not_transitively_reachable);
9995

10096
ADD_STATS_DOUBLE(duration);
10197
val = NULL;

0 commit comments

Comments
 (0)