Address code review

Author: corona10

Include/internal/pycore_optimizer.h

@@ -394,7 +394,7 @@ extern JitOptRef _Py_uop_sym_new_type(
 extern JitOptRef _Py_uop_sym_new_const(JitOptContext *ctx, PyObject *const_val);
 extern JitOptRef _Py_uop_sym_new_const_steal(JitOptContext *ctx, PyObject *const_val);
 bool _Py_uop_sym_is_safe_const(JitOptContext *ctx, JitOptRef sym);
-bool _Py_uop_sym_is_container(JitOptRef sym);
+bool _Py_uop_sym_is_not_container(JitOptRef sym);
 _PyStackRef _Py_uop_sym_get_const_as_stackref(JitOptContext *ctx, JitOptRef sym);
 extern JitOptRef _Py_uop_sym_new_null(JitOptContext *ctx);
 extern bool _Py_uop_sym_has_type(JitOptRef sym);

Python/optimizer_analysis.c

@@ -252,7 +252,7 @@ add_op(JitOptContext *ctx, _PyUOpInstruction *this_instr,
 #define sym_is_not_null _Py_uop_sym_is_not_null
 #define sym_is_const _Py_uop_sym_is_const
 #define sym_is_safe_const _Py_uop_sym_is_safe_const
-#define sym_is_container _Py_uop_sym_is_container
+#define sym_is_not_container _Py_uop_sym_is_not_container
 #define sym_get_const _Py_uop_sym_get_const
 #define sym_new_const_steal _Py_uop_sym_new_const_steal
 #define sym_get_const_as_stackref _Py_uop_sym_get_const_as_stackref

Python/optimizer_bytecodes.c

@@ -515,7 +515,7 @@ dummy_func(void) {
         res = sym_new_not_null(ctx);
         ds = dict_st;
         ss = sub_st;
-        if (!sym_is_container(sub_st) &&
+        if (sym_is_not_container(sub_st) &&
             sym_matches_type(dict_st, &PyFrozenDict_Type)) {
             REPLACE_OPCODE_IF_EVALUATES_PURE(dict_st, sub_st, res);
         }
@@ -707,7 +707,7 @@ dummy_func(void) {
         b = sym_new_type(ctx, &PyBool_Type);
         l = left;
         r = right;
-        if (!sym_is_container(left) &&
+        if (sym_is_not_container(left) &&
             sym_matches_type(right, &PyFrozenSet_Type)) {
             REPLACE_OPCODE_IF_EVALUATES_PURE(left, right, b);
         }

Python/optimizer_cases.c.h

@@ -288,18 +288,17 @@ _Py_uop_sym_is_safe_const(JitOptContext *ctx, JitOptRef sym)
 }
 
 bool
-_Py_uop_sym_is_container(JitOptRef sym)
+_Py_uop_sym_is_not_container(JitOptRef sym)
 {
     PyTypeObject *typ = _Py_uop_sym_get_type(sym);
     if (typ == NULL) {
         return false;
     }
-    return (typ == &PyFrozenSet_Type) ||
-           (typ == &PyFrozenDict_Type) ||
-           (typ == &PySet_Type) ||
-           (typ == &PyDict_Type) ||
-           (typ == &PyList_Type) ||
-           (typ == &PyTuple_Type);
+    return (typ == &PyLong_Type) ||
+           (typ == &PyFloat_Type) ||
+           (typ == &PyUnicode_Type) ||
+           (typ == &_PyNone_Type) ||
+           (typ == &PyBool_Type);
 }
 
 void