Skip to content

Commit 278cefd

Browse files
vstinnergpshead
andcommitted
Enhance test
Co-authored-by: Gregory P. Smith <greg@krypto.org>
1 parent 49a1209 commit 278cefd

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

Lib/test/test_ssl.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2854,6 +2854,7 @@ def run(self):
28542854
context.load_cert_chain(CERTFILE)
28552855
server_sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
28562856
with server_sock:
2857+
server_sock.settimeout(support.SHORT_TIMEOUT)
28572858
server_sock.bind((HOST, 0))
28582859
server_sock.listen(5)
28592860

@@ -2864,10 +2865,9 @@ def run(self):
28642865
sslconn = context.wrap_socket(sock, server_side=True)
28652866
with sslconn:
28662867
request = b''
2867-
while True:
2868-
chunk = sslconn.recv(1024)
2868+
while chunk := sslconn.recv(1024):
28692869
request += chunk
2870-
if b'\n' in request:
2870+
if b'\n' in chunk:
28712871
break
28722872

28732873
sslconn.sendall(b'server\n')
@@ -5039,6 +5039,7 @@ def test_got_eof(self):
50395039
server.start()
50405040
if not server.listening.wait(support.SHORT_TIMEOUT):
50415041
raise RuntimeError("server took too long")
5042+
self.addCleanup(server.join)
50425043

50435044
context = ssl.create_default_context(cafile=CERTFILE)
50445045
sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
@@ -5083,8 +5084,6 @@ def test_got_eof(self):
50835084
# raise an error
50845085
pass
50855086

5086-
server.join()
5087-
50885087

50895088
@unittest.skipUnless(has_tls_version('TLSv1_3') and ssl.HAS_PHA,
50905089
"Test needs TLS 1.3 PHA")

0 commit comments

Comments
 (0)