Skip to content

Commit 1548b6e

Browse files
committed
Remove callback before Py_CLEAR
1 parent dd20d00 commit 1548b6e

1 file changed

Lines changed: 2 additions & 5 deletions

File tree

Modules/_ssl.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5308,13 +5308,10 @@ _ssl__SSLContext_sni_callback_set_impl(PySSLContext *self, PyObject *value)
53085308
"sni_callback cannot be set on TLS_CLIENT context");
53095309
return -1;
53105310
}
5311+
SSL_CTX_set_tlsext_servername_callback(self->ctx, NULL);
53115312
Py_CLEAR(self->set_sni_cb);
5312-
if (value == Py_None) {
5313-
SSL_CTX_set_tlsext_servername_callback(self->ctx, NULL);
5314-
}
5315-
else {
5313+
if (value != Py_None) {
53165314
if (!PyCallable_Check(value)) {
5317-
SSL_CTX_set_tlsext_servername_callback(self->ctx, NULL);
53185315
PyErr_SetString(PyExc_TypeError,
53195316
"not a callable object");
53205317
return -1;

0 commit comments

Comments
 (0)