Handle include_external_packages=None

Author: seddonym

src/grimp/application/usecases.py

@@ -49,7 +49,6 @@ def build_graph(
             "mypackage", "anotherpackage", "onemore", include_external_packages=True,
         )
     """
-
     file_system: AbstractFileSystem = settings.FILE_SYSTEM
 
     found_packages = _find_packages(
@@ -211,7 +210,9 @@ def _scan_imports(
     import_scanner: AbstractImportScanner = settings.IMPORT_SCANNER_CLASS(
         file_system=file_system,
         found_packages=found_packages,
-        include_external_packages=include_external_packages,
+        # Ensure that the passed exclude_type_checking_imports is definitely a boolean,
+        # otherwise the Rust class will error.
+        include_external_packages=bool(include_external_packages),
     )
     return {
         module_file: import_scanner.scan_for_imports(

tests/unit/application/test_usecases.py

@@ -133,3 +133,37 @@ def write(
             if supplied_cache_dir is not sentinel.not_supplied:
                 kwargs["cache_dir"] = supplied_cache_dir
             usecases.build_graph("mypackage", **kwargs)
+
+    def test_forgives_wrong_type_being_passed_to_include_external_packages(self):
+        file_system = FakeFileSystem(
+            contents="""
+                /path/to/mypackage/
+                    __init__.py
+                    foo/
+                        __init__.py
+                        one.py
+                """,
+            content_map={
+                "/path/to/mypackage/foo/one.py": (
+                    "import mypackage.foo.two.green\nfrom .. import Something"
+                ),
+            },
+        )
+
+        class FakePackageFinder(BaseFakePackageFinder):
+            directory_map = {"mypackage": "/path/to/mypackage"}
+
+        with override_settings(FILE_SYSTEM=file_system, PACKAGE_FINDER=FakePackageFinder()):
+            graph = usecases.build_graph(
+                "mypackage",
+                # Note: this should be a bool, but we want to tolerate it,
+                # as Import Linter currently has a bug where it will pass it as None.
+                include_external_packages=None,
+            )
+
+        expected_modules = {
+            "mypackage",
+            "mypackage.foo",
+            "mypackage.foo.one",
+        }
+        assert expected_modules == graph.modules