remove unused ignores.

tobiasraabe · tobiasraabe · commit 6515955fcca7 · 2025-12-28T20:07:52.000+01:00
diff --git a/pyproject.toml b/pyproject.toml
@@ -75,7 +75,7 @@ test = [
     "syrupy>=4.5.0",
     "aiohttp>=3.11.0",     # For HTTPPath tests.
 ]
-typing = ["ty>=0.0.5"]
+typing = ["ty>=0.0.7"]
 
 [project.urls]
 Changelog = "https://pytask-dev.readthedocs.io/en/stable/changes.html"
@@ -166,6 +166,9 @@ filterwarnings = [
     "ignore:The --rsyncdir command line argument:DeprecationWarning",
 ]
 
+[tool.ty.rules]
+unused-ignore-comment = "error"
+
 [tool.ty.src]
 exclude = ["src/_pytask/_hashlib.py"]
 
diff --git a/src/_pytask/cache.py b/src/_pytask/cache.py
@@ -19,20 +19,21 @@
 
 if TYPE_CHECKING:
     from collections.abc import Callable
+    from typing import TypeAlias
+
+    from ty_extensions import Intersection
+
+    Memoized: TypeAlias = "Intersection[Callable[P, R], HasCache]"
 
 P = ParamSpec("P")
 R = TypeVar("R")
 
 
-class MemoizedCallable(Protocol[P, R]):
-    """A callable that has been memoized and has a cache attribute."""
+class HasCache(Protocol):
+    """Protocol for objects that have a cache attribute."""
 
     cache: Cache
 
-    def __call__(self, *args: P.args, **kwargs: P.kwargs) -> R:
-        """Call the memoized function."""
-        ...
-
 
 @define
 class CacheInfo:
@@ -46,7 +47,7 @@ class Cache:
     _sentinel: Any = field(factory=object)
     cache_info: CacheInfo = field(factory=CacheInfo)
 
-    def memoize(self, func: Callable[P, R]) -> MemoizedCallable[P, R]:
+    def memoize(self, func: Callable[P, R]) -> Memoized[P, R]:
         func_module = getattr(func, "__module__", "")
         func_name = getattr(func, "__name__", "")
         prefix = f"{func_module}.{func_name}:"
@@ -68,9 +69,9 @@ def wrapped(*args: P.args, **kwargs: P.kwargs) -> R:
 
             return value
 
-        wrapped.cache = self  # type: ignore[attr-defined]
+        wrapped.cache = self  # ty: ignore[unresolved-attribute]
 
-        return wrapped  # type: ignore[return-value]
+        return wrapped
 
     def add(self, key: str, value: Any) -> None:
         self._cache[key] = value
diff --git a/src/_pytask/click.py b/src/_pytask/click.py
@@ -37,12 +37,10 @@
 if importlib.metadata.version("click") < "8.2":
     from click.parser import split_opt
 else:
-    from click.parser import (  # type: ignore[attr-defined, no-redef, unused-ignore, unresolved-import]
-        _split_opt as split_opt,  # ty: ignore[unresolved-import]
-    )
+    from click.parser import _split_opt as split_opt  # ty: ignore[unresolved-import]
 
 
-class EnumChoice(Choice):  # type: ignore[type-arg, unused-ignore]
+class EnumChoice(Choice):
     """An enum-based choice type.
 
     The implementation is copied from https://github.com/pallets/click/pull/2210 and
@@ -75,7 +73,7 @@ def convert(self, value: Any, param: Parameter | None, ctx: Context | None) -> A
 class _OptionHighlighter(RegexHighlighter):
     """A highlighter for help texts."""
 
-    highlights: ClassVar = [  # type: ignore[misc]
+    highlights: ClassVar = [
         r"(?P<switch>\-\w)\b",
         r"(?P<option>\-\-[\w\-]+)",
         r"\-\-[\w\-]+(?P<metavar>[ |=][\w\.:]+)",
@@ -329,7 +327,7 @@ def _format_help_text(  # noqa: C901, PLR0912, PLR0915
         elif param.is_bool_flag and param.secondary_opts:  # type: ignore[attr-defined]
             # For boolean flags that have distinct True/False opts,
             # use the opt without prefix instead of the value.
-            default_string = split_opt(  # type: ignore[operator, unused-ignore]
+            default_string = split_opt(
                 (param.opts if param.default else param.secondary_opts)[0]
             )[1]
         elif (
diff --git a/src/_pytask/coiled_utils.py b/src/_pytask/coiled_utils.py
@@ -13,7 +13,7 @@
 except ImportError:
 
     @define
-    class Function:  # type: ignore[no-redef]
+    class Function:
         cluster_kwargs: dict[str, Any]
         environ: dict[str, Any]
         function: Callable[..., Any] | None
diff --git a/src/_pytask/collect.py b/src/_pytask/collect.py
@@ -120,7 +120,7 @@ def _collect_from_tasks(session: Session) -> None:
                 raw_task = task_decorator()(raw_task)  # noqa: PLW2901
 
             path = get_file(raw_task)
-            name = raw_task.pytask_meta.name  # ty: ignore[possibly-missing-attribute]
+            name = raw_task.pytask_meta.name
 
         if has_mark(raw_task, "task"):
             # When tasks with @task are passed to the programmatic interface
diff --git a/src/_pytask/collect_command.py b/src/_pytask/collect_command.py
@@ -124,15 +124,11 @@ def _find_common_ancestor_of_all_nodes(
     for task in tasks:
         all_paths.append(task.path)
         if show_nodes:
-            all_paths.extend(  # type: ignore[var-annotated]
-                x.path
-                for x in tree_leaves(task.depends_on)  # type: ignore[arg-type]
-                if isinstance(x, PPathNode)
+            all_paths.extend(
+                x.path for x in tree_leaves(task.depends_on) if isinstance(x, PPathNode)
             )
-            all_paths.extend(  # type: ignore[var-annotated]
-                x.path
-                for x in tree_leaves(task.produces)  # type: ignore[arg-type]
-                if isinstance(x, PPathNode)
+            all_paths.extend(
+                x.path for x in tree_leaves(task.produces) if isinstance(x, PPathNode)
             )
 
     return find_common_ancestor(*all_paths, *paths)
@@ -200,7 +196,7 @@ def _print_collected_tasks(
             )
 
             if show_nodes:
-                deps: list[Any] = list(tree_leaves(task.depends_on))  # type: ignore[arg-type]
+                deps: list[Any] = list(tree_leaves(task.depends_on))
                 for node in sorted(
                     deps,
                     key=(
@@ -212,7 +208,7 @@ def _print_collected_tasks(
                     text = format_node_name(node, (common_ancestor,))
                     task_branch.add(Text.assemble(FILE_ICON, "<Dependency ", text, ">"))
 
-                products: list[Any] = list(tree_leaves(task.produces))  # type: ignore[arg-type]
+                products: list[Any] = list(tree_leaves(task.produces))
                 for node in sorted(
                     products,
                     key=lambda x: x.path.as_posix()
diff --git a/src/_pytask/collect_utils.py b/src/_pytask/collect_utils.py
@@ -112,7 +112,7 @@ def parse_dependencies_from_task_function(
             )
             dependencies[parameter_name] = PythonNode(value=value, name=node_name)
         else:
-            dependencies[parameter_name] = nodes  # type: ignore[assignment]
+            dependencies[parameter_name] = nodes
     return dependencies
 
 
diff --git a/src/_pytask/dag.py b/src/_pytask/dag.py
@@ -88,8 +88,8 @@ def _add_product(
     for task in tasks:
         dag.add_node(task.signature, task=task)
 
-        tree_map(lambda x: _add_dependency(dag, task, x), task.depends_on)  # type: ignore[arg-type]
-        tree_map(lambda x: _add_product(dag, task, x), task.produces)  # type: ignore[arg-type]
+        tree_map(lambda x: _add_dependency(dag, task, x), task.depends_on)
+        tree_map(lambda x: _add_product(dag, task, x), task.produces)
 
         # If a node is a PythonNode wrapped in another PythonNode, it is a product from
         # another task that is a dependency in the current task. Thus, draw an edge
@@ -98,7 +98,7 @@ def _add_product(
             lambda x: dag.add_edge(x.value.signature, x.signature)
             if isinstance(x, PythonNode) and isinstance(x.value, PythonNode)
             else None,
-            task.depends_on,  # type: ignore[arg-type]
+            task.depends_on,
         )
     return dag
 
diff --git a/src/_pytask/data_catalog.py b/src/_pytask/data_catalog.py
@@ -121,7 +121,7 @@ def add(self, name: str, node: PNode | PProvisionalNode | Any = None) -> None:
                     name=name, path=self.path / f"{filename}.pkl"
                 )
             else:
-                self._entries[name] = self.default_node(name=name)  # type: ignore[call-arg]
+                self._entries[name] = self.default_node(name=name)
             self.path.joinpath(f"{filename}-node.pkl").write_bytes(  # type: ignore[union-attr]
                 pickle.dumps(self._entries[name])
             )
diff --git a/src/_pytask/execute.py b/src/_pytask/execute.py
@@ -301,10 +301,8 @@ def pytask_execute_task_teardown(session: Session, task: PTask) -> None:
         return
 
     collect_provisional_products(session, task)
-    missing_nodes: list[Any] = [  # type: ignore[var-annotated]
-        node
-        for node in tree_leaves(task.produces)  # type: ignore[arg-type]
-        if not node.state()
+    missing_nodes: list[Any] = [
+        node for node in tree_leaves(task.produces) if not node.state()
     ]
     if missing_nodes:
         paths = session.config["paths"]
diff --git a/src/_pytask/hookspecs.py b/src/_pytask/hookspecs.py
@@ -166,7 +166,7 @@ def pytask_collect_file_log(session: Session, reports: list[CollectionReport]) -
 @hookspec(firstresult=True)
 def pytask_collect_task_protocol(
     session: Session, path: Path | None, name: str, obj: Any
-) -> CollectionReport | None:  # type: ignore[invalid-return-type]
+) -> CollectionReport | None:
     """Start protocol to collect tasks."""
 
 
@@ -180,7 +180,7 @@ def pytask_collect_task_setup(
 @hookspec(firstresult=True)
 def pytask_collect_task(
     session: Session, path: Path | None, name: str, obj: Any
-) -> PTask:  # type: ignore[invalid-return-type]
+) -> PTask:  # ty: ignore[invalid-return-type]
     """Collect a single task."""
 
 
@@ -196,14 +196,14 @@ def pytask_collect_task_teardown(session: Session, task: PTask) -> None:
 @hookspec(firstresult=True)
 def pytask_collect_node(
     session: Session, path: Path, node_info: NodeInfo
-) -> PNode | PProvisionalNode | None:  # type: ignore[invalid-return-type]
+) -> PNode | PProvisionalNode | None:
     """Collect a node which is a dependency or a product of a task."""
 
 
 @hookspec(firstresult=True)
 def pytask_collect_log(
     session: Session, reports: list[CollectionReport], tasks: list[PTask]
-) -> None:  # type: ignore[invalid-return-type]
+) -> None:
     """Log errors occurring during the collection.
 
     This hook reports errors during the collection.
diff --git a/src/_pytask/path.py b/src/_pytask/path.py
@@ -161,7 +161,7 @@ def import_path(path: Path, root: Path) -> ModuleType:
 
     mod = importlib.util.module_from_spec(spec)
     sys.modules[module_name] = mod
-    spec.loader.exec_module(mod)  # type: ignore[union-attr]
+    spec.loader.exec_module(mod)
     _insert_missing_modules(sys.modules, module_name)
     return mod
 
@@ -334,7 +334,7 @@ def _import_module_using_spec(
     if spec is not None:
         mod = importlib.util.module_from_spec(spec)
         sys.modules[module_name] = mod
-        spec.loader.exec_module(mod)  # type: ignore[union-attr]
+        spec.loader.exec_module(mod)  # ty: ignore[possibly-missing-attribute]
         _insert_missing_modules(sys.modules, module_name)
         return mod
 
diff --git a/src/_pytask/provisional.py b/src/_pytask/provisional.py
@@ -39,9 +39,9 @@ def pytask_execute_task_setup(session: Session, task: PTask) -> None:
     Provisional nodes need to be resolved before the same hook in persist.
 
     """
-    task.depends_on = tree_map_with_path(  # type: ignore[assignment]
+    task.depends_on = tree_map_with_path(
         lambda p, x: collect_provisional_nodes(session, task, x, p),
-        task.depends_on,  # type: ignore[arg-type]
+        task.depends_on,
     )
     if task.signature in TASKS_WITH_PROVISIONAL_NODES:
         recreate_dag(session, task)
diff --git a/src/_pytask/provisional_utils.py b/src/_pytask/provisional_utils.py
@@ -65,7 +65,7 @@ def collect_provisional_nodes(
                 task_name=task_name,
             ),
         ),
-        provisional_nodes,  # type: ignore[arg-type]
+        provisional_nodes,
     )
 
 
@@ -99,9 +99,9 @@ def collect_provisional_products(session: Session, task: PTask) -> None:
         return
 
     # Replace provisional nodes with their actually resolved nodes.
-    task.produces = tree_map_with_path(  # type: ignore[assignment]
+    task.produces = tree_map_with_path(
         lambda p, x: collect_provisional_nodes(session, task, x, p),
-        task.produces,  # type: ignore[arg-type]
+        task.produces,
     )
 
     if task.signature in TASKS_WITH_PROVISIONAL_NODES:
diff --git a/src/_pytask/task_utils.py b/src/_pytask/task_utils.py
@@ -8,6 +8,7 @@
 from types import BuiltinFunctionType
 from typing import TYPE_CHECKING
 from typing import Any
+from typing import TypeVar
 
 import attrs
 
@@ -24,6 +25,13 @@
 if TYPE_CHECKING:
     from collections.abc import Callable
     from pathlib import Path
+    from typing import TypeAlias
+
+    from ty_extensions import Intersection
+
+    TaskDecorated: TypeAlias = "Intersection[T, TaskFunction]"
+
+T = TypeVar("T", bound="Callable[..., Any]")
 
 
 __all__ = [
@@ -52,7 +60,7 @@ def task(  # noqa: PLR0913
     id: str | None = None,  # noqa: A002
     kwargs: dict[Any, Any] | None = None,
     produces: Any | None = None,
-) -> Callable[..., Callable[..., Any]]:
+) -> Callable[[T], TaskDecorated[T]]:
     """Decorate a task function.
 
     This decorator declares every callable as a pytask task.
@@ -110,7 +118,7 @@ def create_text_file() -> Annotated[str, Path("file.txt")]:
 
     """
 
-    def wrapper(func: Callable[..., Any]) -> Callable[..., Any]:
+    def wrapper(func: T) -> TaskDecorated[T]:
         # Omits frame when a builtin function is wrapped.
         _rich_traceback_omit = True
 
@@ -209,7 +217,7 @@ def _parse_after(
         for func in after:
             if not isinstance(func, TaskFunction):
                 func = task()(func)  # noqa: PLW2901
-            new_after.append(func.pytask_meta._id)  # type: ignore[attr-defined]
+            new_after.append(func.pytask_meta._id)
         return new_after
     msg = (
         "'after' should be an expression string, a task, or a list of tasks. Got "
diff --git a/tests/test_jupyter/test_functional_interface.ipynb b/tests/test_jupyter/test_functional_interface.ipynb
@@ -44,7 +44,7 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "session = pytask.build(tasks=[create_file, create_text])  # type: ignore[arg-type]\n",
+    "session = pytask.build(tasks=[create_file, create_text])\n",
     "assert session.exit_code == ExitCode.OK"
    ]
   }
diff --git a/tests/test_jupyter/test_functional_interface_w_relative_path.ipynb b/tests/test_jupyter/test_functional_interface_w_relative_path.ipynb
@@ -44,7 +44,7 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "session = pytask.build(tasks=[create_file, create_text])  # type: ignore[arg-type]\n",
+    "session = pytask.build(tasks=[create_file, create_text])\n",
     "assert session.exit_code == ExitCode.OK"
    ]
   }
diff --git a/tests/test_outcomes.py b/tests/test_outcomes.py
@@ -11,7 +11,7 @@
 
 @pytest.mark.parametrize("outcome_in_report", CollectionOutcome)
 def test_count_outcomes_collection(outcome_in_report):
-    reports = [CollectionReport(outcome_in_report, None, None)]  # type: ignore[arg-type]
+    reports = [CollectionReport(outcome_in_report, None, None)]
 
     counts = count_outcomes(reports, CollectionOutcome)
 
diff --git a/tests/test_path.py b/tests/test_path.py
@@ -146,7 +146,7 @@ def simple_module(request, tmp_path: Path) -> Generator[Path, None, None]:
 def test_importmode_importlib(request, simple_module: Path, tmp_path: Path) -> None:
     """`importlib` mode does not change sys.path."""
     module = import_path(simple_module, root=tmp_path)
-    assert module.foo(2) == 42  # type: ignore[attr-defined]
+    assert module.foo(2) == 42
     assert str(simple_module.parent) not in sys.path
     assert module.__name__ in sys.modules
     assert module.__name__ == f"_src.project.mymod_{request.node.name}"
@@ -167,7 +167,7 @@ def test_no_meta_path_found(
     """Even without any meta_path should still import module."""
     monkeypatch.setattr(sys, "meta_path", [])
     module = import_path(simple_module, root=tmp_path)
-    assert module.foo(2) == 42  # type: ignore[attr-defined]
+    assert module.foo(2) == 42
 
     # mode='importlib' fails if no spec is found to load the module
     import importlib.util  # noqa: PLC0415
diff --git a/tests/test_persist.py b/tests/test_persist.py
@@ -132,7 +132,7 @@ def test_pytask_execute_task_process_report(monkeypatch, exc_info, expected):
     session = Mock(dag=None)
     report = Mock(exc_info=exc_info, task=task)
 
-    result = pytask_execute_task_process_report(session, report)  # type: ignore[arg-type]
+    result = pytask_execute_task_process_report(session, report)
 
     if expected:
         assert report.outcome == TaskOutcome.PERSISTENCE
diff --git a/tests/test_task_utils.py b/tests/test_task_utils.py
diff --git a/uv.lock b/uv.lock

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ def parse_dependencies_from_task_function(`
`112`	`112`	`)`
`113`	`113`	`dependencies[parameter_name] = PythonNode(value=value, name=node_name)`
`114`	`114`	`else:`
`115`		`- dependencies[parameter_name] = nodes # type: ignore[assignment]`
	`115`	`+ dependencies[parameter_name] = nodes`
`116`	`116`	`return dependencies`
`117`	`117`
`118`	`118`
Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ def add(self, name: str, node: PNode \| PProvisionalNode \| Any = None) -> None:`
`121`	`121`	`name=name, path=self.path / f"{filename}.pkl"`
`122`	`122`	`)`
`123`	`123`	`else:`
`124`		`- self._entries[name] = self.default_node(name=name) # type: ignore[call-arg]`
	`124`	`+ self._entries[name] = self.default_node(name=name)`
`125`	`125`	`self.path.joinpath(f"{filename}-node.pkl").write_bytes( # type: ignore[union-attr]`
`126`	`126`	`pickle.dumps(self._entries[name])`
`127`	`127`	`)`