From e3fc9c72ac70108f57816f9746d4d0b148036163 Mon Sep 17 00:00:00 2001 From: r0hansaxena Date: Wed, 4 Mar 2026 13:29:23 +0530 Subject: [PATCH 1/5] Fix inexistent function reference in poa_components docstring --- pvlib/irradiance.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvlib/irradiance.py b/pvlib/irradiance.py index c67c1ca251..78c50e8bb1 100644 --- a/pvlib/irradiance.py +++ b/pvlib/irradiance.py @@ -490,7 +490,7 @@ def poa_components(aoi, dni, poa_sky_diffuse, poa_ground_diffuse): poa_ground_diffuse : numeric Ground-reflected irradiance in the plane of the modules, - as calculated by an albedo model (eg. :func:`grounddiffuse`). [Wm⁻²] + as calculated by an albedo model (eg. :py:func:`pvlib.irradiance.get_ground_diffuse`). [Wm⁻²] Returns ------- From f4d58da1e3d58b353d1e30f2140ee9e347df0bc8 Mon Sep 17 00:00:00 2001 From: r0hansaxena Date: Wed, 4 Mar 2026 14:02:50 +0530 Subject: [PATCH 2/5] Add whatsnew entry for #2089 --- docs/sphinx/source/whatsnew/v0.15.1.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/sphinx/source/whatsnew/v0.15.1.rst b/docs/sphinx/source/whatsnew/v0.15.1.rst index 83b13d01f0..3552bd144d 100644 --- a/docs/sphinx/source/whatsnew/v0.15.1.rst +++ b/docs/sphinx/source/whatsnew/v0.15.1.rst @@ -38,6 +38,9 @@ Documentation * Add AI checkbox to PR template, and auto-generate a comment on PRs from first-time contributors regarding AI and contributing guidelines. (:issue:`2617`, :pull:`2624`) +* Fix a broken docstring reference to ``grounddiffuse`` in + :py:func:`pvlib.irradiance.poa_components` + (:issue:`2089`, :ghuser:`r0hansaxena`) Testing From 3ab48e0ad1d0dcc3987e586f94ebe23fd7f8fc65 Mon Sep 17 00:00:00 2001 From: r0hansaxena Date: Wed, 4 Mar 2026 21:44:13 +0530 Subject: [PATCH 3/5] Update pvlib/irradiance.py Co-authored-by: Cliff Hansen --- pvlib/irradiance.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pvlib/irradiance.py b/pvlib/irradiance.py index 78c50e8bb1..362fa39a5c 100644 --- a/pvlib/irradiance.py +++ b/pvlib/irradiance.py @@ -490,7 +490,8 @@ def poa_components(aoi, dni, poa_sky_diffuse, poa_ground_diffuse): poa_ground_diffuse : numeric Ground-reflected irradiance in the plane of the modules, - as calculated by an albedo model (eg. :py:func:`pvlib.irradiance.get_ground_diffuse`). [Wm⁻²] + as calculated by an albedo model (eg., + :py:func:`pvlib.irradiance.get_ground_diffuse`). [Wm⁻²] Returns ------- From 082d417847e70cba3559f2923b7e96366ea5d9b9 Mon Sep 17 00:00:00 2001 From: r0hansaxena Date: Wed, 4 Mar 2026 22:31:41 +0530 Subject: [PATCH 4/5] Update pvlib/irradiance.py Co-authored-by: Cliff Hansen --- pvlib/irradiance.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvlib/irradiance.py b/pvlib/irradiance.py index 362fa39a5c..bc2448b036 100644 --- a/pvlib/irradiance.py +++ b/pvlib/irradiance.py @@ -491,7 +491,7 @@ def poa_components(aoi, dni, poa_sky_diffuse, poa_ground_diffuse): poa_ground_diffuse : numeric Ground-reflected irradiance in the plane of the modules, as calculated by an albedo model (eg., - :py:func:`pvlib.irradiance.get_ground_diffuse`). [Wm⁻²] + :py:func:`~pvlib.irradiance.get_ground_diffuse`). [Wm⁻²] Returns ------- From 17903b5f77cf1088038609d3e8f553c54b639e5c Mon Sep 17 00:00:00 2001 From: r0hansaxena Date: Wed, 4 Mar 2026 22:46:58 +0530 Subject: [PATCH 5/5] Fix docstring reference and update contributors list Updated issue references and added contributor. --- docs/sphinx/source/whatsnew/v0.15.1.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/sphinx/source/whatsnew/v0.15.1.rst b/docs/sphinx/source/whatsnew/v0.15.1.rst index 3552bd144d..5e93232eed 100644 --- a/docs/sphinx/source/whatsnew/v0.15.1.rst +++ b/docs/sphinx/source/whatsnew/v0.15.1.rst @@ -40,7 +40,7 @@ Documentation (:issue:`2617`, :pull:`2624`) * Fix a broken docstring reference to ``grounddiffuse`` in :py:func:`pvlib.irradiance.poa_components` - (:issue:`2089`, :ghuser:`r0hansaxena`) + (:issue:`2089`, :pull:`2708`) Testing @@ -69,4 +69,5 @@ Contributors * Cliff Hansen (:ghuser:`cwhanse`) * Anton Driesse (:ghuser:`adriesse`) * Kevin Anderson (:ghuser:`kandersolar`) +* Rohan Saxena (:ghuser:`r0hansaxena`)