Description
In nw_server_status/server_status.py, there is a critical bug where an async function is called without await, causing the coroutines to never execute.
Location
File: nw_server_status/server_status.py
Line: 134
Current Code
async def update_monitor_channels(self):
for guild in self.bot.guilds:
self.update_guild_channel(guild) # ❌ Missing await!
Impact
- Monitor channels are never updated because the coroutines are created but never awaited
- This creates a
RuntimeWarning in Python 3.10+: "coroutine was never awaited"
- The entire monitor channel feature is non-functional
Expected Behavior
The monitor channels should update periodically with server status information.
Fix Required
async def update_monitor_channels(self):
for guild in self.bot.guilds:
await self.update_guild_channel(guild) # ✅ Fixed
Priority
CRITICAL - This breaks the core functionality of the cog.
Testing
After fixing, verify that:
- Monitor channels are properly updated every 5 minutes
- No
RuntimeWarning appears in logs
- Server status information is correctly displayed
Related
This is part of a comprehensive code review. See other issues for additional improvements.
Description
In
nw_server_status/server_status.py, there is a critical bug where an async function is called withoutawait, causing the coroutines to never execute.Location
File:
nw_server_status/server_status.pyLine: 134
Current Code
Impact
RuntimeWarningin Python 3.10+: "coroutine was never awaited"Expected Behavior
The monitor channels should update periodically with server status information.
Fix Required
Priority
CRITICAL - This breaks the core functionality of the cog.
Testing
After fixing, verify that:
RuntimeWarningappears in logsRelated
This is part of a comprehensive code review. See other issues for additional improvements.