Skip to content
This repository was archived by the owner on Jul 7, 2021. It is now read-only.

Commit 93df483

Browse files
committed
#14: Stabilize code of Banks services: finish implementation and write tests
1 parent 975be3c commit 93df483

2 files changed

Lines changed: 9 additions & 3 deletions

File tree

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ This library is in early alpha version and not all API methods are implemented y
3232

3333
- Authorization
3434
- [x] Get tokens
35-
- [ ] Revoke a token
35+
- [x] Revoke a token
3636
- Mandator administration
3737
- [ ] Get user list
3838
- [ ] Delete users
@@ -51,9 +51,9 @@ This library is in early alpha version and not all API methods are implemented y
5151
- [x] Delete the authorized user
5252
- [ ] Delete an unverified user
5353
- Banks
54-
- [ ] Get a bank
54+
- [x] Get a bank
5555
- [ ] ~~Get a multiple banks~~ (won't be implemented as deprecated)
56-
- [ ] Get and search all banks
56+
- [x] Get and search all banks (:exclamation: no paging)
5757
- Bank connections
5858
- [ ] Get a bank connection
5959
- [ ] ~~Get multiple bank connections~~ (won't be implemented as deprecated)

src/main/java/org/proshin/finapi/bank/FpBanks.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,12 @@ public Bank one(final Long id) {
4040
);
4141
}
4242

43+
/**
44+
* Get and search all banks service.
45+
* @param criteria Search options.
46+
* @return a list of found banks
47+
* @todo #14 Implement paging for service "Banks - Get and search all banks" (find a way to make it generic)
48+
*/
4349
@Override
4450
public Iterable<Bank> search(final QueryCriteria criteria) {
4551
return new IterableJsonArray<>(

0 commit comments

Comments
 (0)