You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Syncs the Kalshi vendor OpenAPI spec with upstream API changes: adds a subaccount query parameter to the balance endpoint, adds balance_dollars to the balance response schema, adds ts_ms to the order schema, and removes a stale client_order_id field from the fill schema. The generated api.ts is regenerated to match.
Blast Radius
core/specs/kalshi/Kalshi.yaml -- vendor spec (source of truth for api.ts generation)
Generated file header leaks local path: api.ts line 2 now reads Auto-generated from /Users/samueltinnerholm/Documents/GitHub/pmxt/.claude/worktrees/agent-a6e1b73d/.... This embeds a user-specific local filesystem path into the committed file. The generation script should use a relative path or a stable placeholder instead.
Removing client_order_id from Fill schema is a breaking change for spec consumers -- any downstream code that relied on client_order_id in the fill response type will break. However, since this reflects an upstream Kalshi API change (the field no longer exists in their response), the spec must track reality.
New fields (balance_dollars, ts_ms, subaccount) are additive -- no normalizer changes needed since these are raw spec fields, not unified types. The normalizer already handles the balance conversion from cents to dollars and does not reference these new fields yet.
PMXT Pipeline Check
Field propagation: N/A (vendor spec fields, not unified types)
OpenAPI sync: OK (api.ts regenerated from spec)
Type safety: OK
Semver Impact
patch -- upstream spec sync; no unified type changes.
Risk
The local filesystem path in api.ts should be cleaned up before merge.
client_order_id removal is technically breaking for any code parsing raw Kalshi fills, but this reflects upstream reality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #542
Fixes #517
Fixes #522
Fixes #433