From 8ba89a060c62e31637d8ab91023fb929fa238430 Mon Sep 17 00:00:00 2001
From: "Samuel EF. Tinnerholm" <samuel.tinnerholm@gmail.com>
Date: Sun, 24 May 2026 17:52:20 +0300
Subject: [PATCH] fix: add env fallbacks for hardcoded service URLs

Fixes #508
---
 core/src/exchanges/opinion/config.ts    | 4 ++--
 core/src/router/client.ts               | 2 +-
 core/src/subscriber/external/goldsky.ts | 9 ++++++---
 3 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/core/src/exchanges/opinion/config.ts b/core/src/exchanges/opinion/config.ts
index 6e38f63b..efe199ad 100644
--- a/core/src/exchanges/opinion/config.ts
+++ b/core/src/exchanges/opinion/config.ts
@@ -1,5 +1,5 @@
-export const DEFAULT_OPINION_API_URL = "https://proxy.opinion.trade:8443/openapi";
-export const OPINION_WS_URL = "wss://ws.opinion.trade";
+export const DEFAULT_OPINION_API_URL = process.env.OPINION_API_URL || "https://proxy.opinion.trade:8443/openapi";
+export const OPINION_WS_URL = process.env.OPINION_WS_URL || "wss://ws.opinion.trade";
 export const OPINION_MAX_PAGE_SIZE = 20;
 
 // CLOB SDK chain constants
diff --git a/core/src/router/client.ts b/core/src/router/client.ts
index 637f3a5a..fb1806da 100644
--- a/core/src/router/client.ts
+++ b/core/src/router/client.ts
@@ -15,7 +15,7 @@ import type {
     RouterEventSearchParams,
 } from './types';
 
-const DEFAULT_BASE_URL = 'https://api.pmxt.dev';
+const DEFAULT_BASE_URL = process.env.PMXT_API_URL || 'https://api.pmxt.dev';
 
 export class PmxtApiClient {
     private readonly http: AxiosInstance;
diff --git a/core/src/subscriber/external/goldsky.ts b/core/src/subscriber/external/goldsky.ts
index 5fe7d1df..419aedf2 100644
--- a/core/src/subscriber/external/goldsky.ts
+++ b/core/src/subscriber/external/goldsky.ts
@@ -54,9 +54,12 @@ export interface GoldSkyConfig extends Omit<SubscriberConfig, 'buildSubscription
 // ----------------------------------------------------------------------------
 
 // Reference: https://docs.polymarket.com/market-data/subgraph
-const POLYMARKET_TRADES_ENDPOINT =
+const POLYMARKET_TRADES_ENDPOINT = process.env.POLYMARKET_GOLDSKY_URL ||
     'https://api.goldsky.com/api/public/project_cl6mb8i9h0003e201j6li0diw/subgraphs/orderbook-subgraph/prod/gn';
 
+const GOLDSKY_MAKER_TRADES_LIMIT = 5;
+const GOLDSKY_TAKER_TRADES_LIMIT = 20;
+
 // NOTE: orderBy must use `id` (primary key) on pnl-subgraph and positions-subgraph.
 // Sorting by any unindexed column (e.g. amount, balance) causes a statement timeout.
 
@@ -80,7 +83,7 @@ const BUILD_POLYMARKET_TRADES_AS_MAKER_QUERY = (address: string, url?: string):
         query GetPolymarketTradesMaker($address: Bytes!) {
             orderFilledEvents(
                 where: { maker: $address }
-                first: 5
+                first: ${GOLDSKY_MAKER_TRADES_LIMIT}
                 orderBy: timestamp
                 orderDirection: desc
             ) {${TRADES_FIELDS}
@@ -96,7 +99,7 @@ const BUILD_POLYMARKET_TRADES_AS_TAKER_QUERY = (address: string, url?: string):
         query GetPolymarketTradesTaker($address: Bytes!) {
             orderFilledEvents(
                 where: { taker: $address }
-                first: 20
+                first: ${GOLDSKY_TAKER_TRADES_LIMIT}
                 orderBy: timestamp
                 orderDirection: desc
             ) {${TRADES_FIELDS}