fix: add env fallbacks for hardcoded RPC endpoints#583
Merged
Conversation
Contributor
Author
PR Review: PASS (NOT VERIFIED)What This DoesExtracts hardcoded RPC endpoint URLs into environment-variable-backed constants for Limitless (Base chain) and Opinion (BSC chain). Creates a new Blast Radius
Findings
PMXT Pipeline Check
Semver Impactpatch -- no public API change; internal infrastructure improvement for deployment flexibility RiskNo runtime verification that the env var override actually works end-to-end (e.g., connecting to a custom RPC). The change is safe by construction since the default is unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #507