Clarify sscanf %c whitespace note

Author: prateekbhujel

UPGRADING

@@ -102,9 +102,9 @@ PHP 8.6 UPGRADE NOTES
 - Standard:
   . Form feed (\f) is now added in the default trimmed characters of trim(),
     rtrim() and ltrim(). RFC: https://wiki.php.net/rfc/trim_form_feed
-  . sscanf() and fscanf() now make the %c conversion consume whitespace.
-    Previously, the conversion stopped at whitespace even though %c does not
-    skip leading whitespace.
+  . sscanf() and fscanf() %c conversions no longer stop at whitespace. They
+    still do not skip leading whitespace; whitespace is now consumed and
+    assigned as part of the result.
   . array_filter() now raises a ValueError when an invalid $mode
     argument value is passed.
   . array_change_key_case() now raises a ValueError when an invalid $case

ext/standard/scanf.c

@@ -833,7 +833,7 @@ PHPAPI int php_sscanf_internal( char *string, char *format,
 				end = string;
 				while (*end != '\0') {
 					sch = *end;
-					if (op == 's' && isspace((unsigned char) sch)) {
+					if (op == 's' && isspace( (unsigned char)sch ) ) {
 						break;
 					}
 					end++;