Converter fixes + safer Tier 2 deploy#47
Open
kirkabowman wants to merge 1 commit into
Open
Conversation
- fm_xml_to_snippet: handle calculated Go to Layout (LayoutNameByCalc / LayoutNumberByCalc) — previously dropped the calc, producing <unknown> in Script Workspace. - fm_xml_to_snippet: add Perform Find by Natural Language handler (LLMCreateFind wrapper with AccountName, Model, PromptMessage, Action, PromptTemplateName) — previously emitted only Field/Action and FM showed all params blank. - step-catalog: correct Go to Layout enum values from LayoutNameByCalculation / LayoutNumberByCalculation to FM's actual LayoutNameByCalc / LayoutNumberByCalc. - deploy.py: Tier 2 Phase 2 now polls up to 3s for the target tab and aborts cleanly if it never appears, instead of blind-pressing Cmd+A on whatever has focus. Prevents catastrophic mis-paste when the script list (not the editor tab) is focused. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fm_xml_to_snippet.py— handle calculatedGo to Layout(LayoutNameByCalc/LayoutNumberByCalc); previously dropped the formula and produced<unknown>in Script Workspace.fm_xml_to_snippet.py— add a dedicated handler forPerform Find by Natural Languageso all six SaXML params (Target,LLMAccountName,LLMModel,LLMMessage,Parameters,LLMAction,TemplateName) get emitted under the<LLMCreateFind>wrapper FM expects. Previously the converter only emittedField+ a malformedAction, and FM rendered every parameter blank.step-catalog-en.json— correctGo to Layoutenum values fromLayoutNameByCalculation/LayoutNumberByCalculationto FM's actualLayoutNameByCalc/LayoutNumberByCalc(confirmed by capturing a working step from FM Pro 22's clipboard).deploy.py— Tier 2 Phase 2 (paste from outside FM) now polls up to 3 s for the target script tab to appear and aborts cleanly if it never does. Without this, a failed Phase 1 (e.g. MBS couldn't open the script because folders were collapsed) led to Phase 2 blindly sending Cmd+A to whatever had focus — selecting the entire script list and prompting to delete every script.Test plan
Go to Layout [ <calculated value> ]viafm_xml_to_snippet.pyand confirm the calc text appears in the resulting<Layout id="0" name=""><Calculation>…</Calculation></Layout>block; paste into Script Workspace and verify FM renders the formula instead of<unknown>.Perform Find by Natural Languagewith all six parameters set; paste into FM and verify Account Name / Model / Prompt / Get / Response Target / Prompt Template Name all render with their values populated.python3 agent/scripts/deploy.py --tier 2 --replace <script>.xml "<Script Name>"with the script list panel focused (not an editor tab). Confirm the deploy aborts with(Fell back from Tier 2: Script opened but paste failed: unknown)instead of selecting all scripts.🤖 Generated with Claude Code