Improve script deployment targeting reliability#37
Open
kirkabowman wants to merge 1 commit into
Open
Conversation
- deploy.py: add hidden-window fallback so target files in Window > Show
Window submenu are unhidden before paste; use exact-name matching
("File.fmp12" or "File") to avoid prefix collisions; switch from
keystrokes to menu actions for Select All / Paste so OnLayoutKeystroke
triggers on the active layout do not fire during deployment.
- filemaker/agentic-fm.xml: call MBS ScriptWorkspace.ExpandScriptFolders
three times before opening the target script so nested folder scripts
are reachable.
- companion_server.py: tighten /trigger document targeting to exact name
match instead of "name contains" — prevents A2X_General matching
A2X_General_data when both are open.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three related fixes to make script deployment hit the intended target reliably:
deploy.py— add a hidden-window fallback (Window → Show Window submenu) so files that aren't currently visible get unhidden before paste. Switch to exact-name matching (name is "File.fmp12" or name is "File") instead ofname contains, which was matchingA2X_Generalagainst bothA2X_GeneralandA2X_General_data. Replace keystroke-based Select All / Paste with menu actions to avoid triggering OnLayoutKeystroke triggers on the active FM layout during deployment.filemaker/agentic-fm.xml— callMBS("ScriptWorkspace.ExpandScriptFolders")three times before opening the target script, so scripts inside nested folder groups are reachable byOpenScript.agent/scripts/companion_server.py— same exact-name match treatment for/trigger's document selection AppleScript, preventing the same prefix-collision class of bug.Test plan
A2X_GeneralandA2X_General_data); deploy a script targetingA2X_Generaland confirm it lands in the right file🤖 Generated with Claude Code