Skip to content

Commit bd0eb4e

Browse files
committed
try removing binding step
1 parent f80769a commit bd0eb4e

3 files changed

Lines changed: 4 additions & 3 deletions

File tree

payjoin-ffi/Cargo.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@ uniffi-dart = { git = "https://github.com/Uniffi-Dart/uniffi-dart.git", tag = "v
4040
url = "2.5.4"
4141

4242
# getrandom is ignored here because it's required by the wasm_js feature
43-
# Even though it may appear unused in the default feature set, it's a legitimate dependency for WASM builds.
43+
# icu deps are ignored here because they're required to be pinned as transitive deps of url
44+
# Even though they may appear unused in the default feature set, they are legitimate dependencies.
4445
[package.metadata.cargo-machete]
4546
ignored = ["getrandom", "icu_provider", "icu_locale_core"]
4647

payjoin-ffi/javascript/scripts/generate_bindings.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ fi
1717
# Heinous hack to pin transitive dependencies to be MSRV compatible on 1.85
1818
cd node_modules/uniffi-bindgen-react-native
1919
cargo add home@=0.5.11 --package uniffi-bindgen-react-native
20-
cargo add icu_locale_core@=2.0.1 --package uniffi-bindgen-react-native
21-
cargo add icu_provider@=2.0.0 --package uniffi-bindgen-react-native
2220
cd ../..
2321

2422
rustup target add wasm32-unknown-unknown

payjoin-ffi/javascript/test-utils/Cargo.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ tokio = { version = "1.47.1", features = ["full"] }
1515
icu_locale_core = "=2.0.1"
1616
icu_provider = "=2.0.0"
1717

18+
# icu deps are ignored here because they're required to be pinned as transitive deps of url
19+
# Even though they may appear unused in the default feature set, they are legitimate dependencies.
1820
[package.metadata.cargo-machete]
1921
ignored = ["icu_provider", "icu_locale_core"]
2022

0 commit comments

Comments
 (0)