Add better connection management UI and subprocess for running connection

Author: Peng Ren

media/connection-editor.js

@@ -1,4 +1,16 @@
 const vscode = acquireVsCodeApi();
+
+function maskPasswordInUri(uri) {
+  try {
+    return uri.replace(
+      /(:\/\/[^:/?#]+):([^@]+)@/,
+      (_, prefix) => prefix + ":***@",
+    );
+  } catch {
+    return uri;
+  }
+}
+
 const initial = window.__SQL4ALL_CONNECTION_EDITOR__ || {
   name: "",
   connection: {
@@ -324,8 +336,9 @@ if (dbTypeWidget) {
     // Restore the saved connection string if it was manually edited
     if (initial.connection.connectionString) {
       const connStringEl = document.getElementById("connectionString");
-      if (connStringEl.value !== initial.connection.connectionString) {
-        connStringEl.value = initial.connection.connectionString;
+      const maskedConnectionString = maskPasswordInUri(initial.connection.connectionString);
+      if (connStringEl.value !== maskedConnectionString) {
+        connStringEl.value = maskedConnectionString;
         connStringEl.dataset.manuallyEdited = "true";
       }
     }

media/sql-executor.css

@@ -749,6 +749,13 @@ body.is-resizing {
   color: var(--vscode-testing-iconFailed, #ff8f8f);
 }
 
+.no-data-cell {
+  text-align: center;
+  padding: 24px !important;
+  color: var(--text-secondary);
+  font-style: italic;
+}
+
 body.vscode-light #queryEditor .cm-keyword,
 body.vscode-high-contrast-light #queryEditor .cm-keyword {
   color: #0000ff;

media/sql-executor.js

@@ -231,12 +231,12 @@ function renderResultsTable(payload, elapsedSeconds) {
     return;
   }
 
-  if (rows.length === 0 || columns.length === 0) {
+  if (columns.length === 0) {
     setResultMetrics(0, 0);
     setExportState(false);
-    renderPlaceholder("Execution returned no rows.", "neutral");
+    renderPlaceholder("Execution returned no data.", "neutral");
     setResultStatus(
-      `Execution completed with no returned rows. (${utils.formatElapsedSeconds(elapsedSeconds || 0)}s)`,
+      `Execution completed with no returned data. (${utils.formatElapsedSeconds(elapsedSeconds || 0)}s)`,
       "neutral",
     );
     return;
@@ -264,6 +264,26 @@ function renderResultsTable(payload, elapsedSeconds) {
   table.appendChild(thead);
 
   const tbody = document.createElement("tbody");
+
+  if (rows.length === 0) {
+    setResultMetrics(0, 0);
+    setExportState(false);
+    const tr = document.createElement("tr");
+    const td = document.createElement("td");
+    td.colSpan = columns.length + 1;
+    td.className = "no-data-cell";
+    td.textContent = "No data";
+    tr.appendChild(td);
+    tbody.appendChild(tr);
+    table.appendChild(tbody);
+    container.innerHTML = "";
+    container.appendChild(table);
+    setResultStatus(
+      `Returned 0 rows. (${utils.formatElapsedSeconds(elapsedSeconds || 0)}s)`,
+      "neutral",
+    );
+    return;
+  }
   rows.forEach((row, index) => {
     const tr = document.createElement("tr");
 

package.json

@@ -3,7 +3,7 @@
   "displayName": "SQL For ALL",
   "publisher": "sql4all",
   "description": "Query SQL/NoSQL Databases using SQL — powered by SQLAlchemy",
-  "version": "0.4.1",
+  "version": "0.5.0",
   "license": "MIT",
   "engines": {
     "vscode": "^1.110.0"
@@ -79,12 +79,6 @@
         "category": "SQL4ALL",
         "icon": "$(trash)"
       },
-      {
-        "command": "sql4all.refreshConnections",
-        "title": "Refresh Connections",
-        "category": "SQL4ALL",
-        "icon": "$(refresh)"
-      },
       {
         "command": "sql4all.selectPythonExecutable",
         "title": "SQL4ALL: Select Python Executable",
@@ -109,6 +103,18 @@
         "category": "SQL4ALL",
         "icon": "$(plug)"
       },
+      {
+        "command": "sql4all.disconnectDatabase",
+        "title": "Disconnect...",
+        "category": "SQL4ALL",
+        "icon": "$(debug-disconnect)"
+      },
+      {
+        "command": "sql4all.refreshConnection",
+        "title": "Refresh...",
+        "category": "SQL4ALL",
+        "icon": "$(refresh)"
+      },
       {
         "command": "sql4all.exportConnections",
         "title": "Export Connections",
@@ -148,11 +154,6 @@
           "when": "view == sql4all.connections",
           "group": "navigation@1"
         },
-        {
-          "command": "sql4all.refreshConnections",
-          "when": "view == sql4all.connections",
-          "group": "navigation@2"
-        },
         {
           "command": "sql4all.importConnections",
           "when": "view == sql4all.connections",
@@ -167,27 +168,37 @@
       "view/item/context": [
         {
           "command": "sql4all.connectConnection",
-          "when": "view == sql4all.connections && viewItem == sql4all.connectionItem",
+          "when": "view == sql4all.connections && viewItem =~ /^sql4all\\.connectionItem/",
           "group": "inline@1"
         },
         {
           "command": "sql4all.connectDatabase",
           "when": "view == sql4all.connections && viewItem == sql4all.connectionItem",
           "group": "1_connect@1"
         },
+        {
+          "command": "sql4all.disconnectDatabase",
+          "when": "view == sql4all.connections && viewItem == sql4all.connectionItem.connected",
+          "group": "1_connect@2"
+        },
+        {
+          "command": "sql4all.refreshConnection",
+          "when": "view == sql4all.connections && viewItem == sql4all.connectionItem.connected",
+          "group": "1_connect@3"
+        },
         {
           "command": "sql4all.editConnection",
-          "when": "view == sql4all.connections && viewItem == sql4all.connectionItem",
+          "when": "view == sql4all.connections && viewItem =~ /^sql4all\\.connectionItem/",
           "group": "2_manage@1"
         },
         {
           "command": "sql4all.deleteConnection",
-          "when": "view == sql4all.connections && viewItem == sql4all.connectionItem",
+          "when": "view == sql4all.connections && viewItem =~ /^sql4all\\.connectionItem/",
           "group": "2_manage@2"
         },
         {
           "command": "sql4all.reloadDriver",
-          "when": "view == sql4all.connections && viewItem == sql4all.connectionItem",
+          "when": "view == sql4all.connections && viewItem =~ /^sql4all\\.connectionItem/",
           "group": "3_driver@1"
         },
         {