Conditional filtering

[vova07]

Hi there again,
Thanks for nice filter tool.

Will try to be short, here is my problem:

What

$validator = new Validator();
$validator->required('title')->string()->lengthBetween(0, 255);
$validator->optional('slug')->string()->lengthBetween(0, 255);

$filter = new Filter();
$filter->value('slug')->slug('title');

$data = [
  'title' => 'Test title',
  'slug' => 'test-slug',
];

$result = $validator->validate($data);
$values = $filter->filter($result->getValues());

var_dump($values);

/*
[
  'title' => 'Test title',
  'slug' => 'testslug'
]

'slug' => 'testslug' instead of 'slug' => 'test-slug' because slug filter is call any time even if `slug` value is set.
*/

What is expected

$validator = new Validator();
$validator->required('title')->string()->lengthBetween(0, 255);
$validator->optional('slug')->string()->lengthBetween(0, 255);

$filter = new Filter();
$filter->value('slug')->skip(function ($value) { return !empty($value); })->slug('title');

$data = [
  'title' => 'Test title',
  'slug' => 'test-slug',
];

$result = $validator->validate($data);
$values = $filter->filter($result->getValues());

var_dump($values);

/*
[
  'title' => 'Test title',
  'slug' => 'test-slug'
]
*/

My suggestion is to add something that will give a possibility to skip filtering when value for filtered key is set, or maybe for any condition.
I know that filter is call to filter, but without own code we cannot obtain wondered behavior.

If I miss something please share a link to solution.

Thanks!

[creocoder]

Why not use:

$data = [
  'title' => 'Test title',
  'slug' => 'test-slug',
];

$filter = new Filter();

if ($data['slug']) !== '') { // any condition you want there
    $filter->value('slug')->slug('title');
}

?

[vova07]

I know that filter is call to filter, but without own code we cannot obtain wondered behavior.

I know how to solve it behind the Filter.
But my question is related with by default solution and functionality.

[rick-nu]

Good point, so we need something to stop the filter chain when a condition is met. We should introduce something like:

$filter->value('slug')->skipIfSet();
$filter->value('slug')->skipIf(function($value){ return $value !== ''; });

[creocoder]

@RickvdStaaij I think it's better to add option to Slug filter and not overcomplicate filter api with excess methods ;-)

[creocoder]

@RickvdStaaij Issue also does not exists with correct usual workflow:

• pre-filter
• validate

So example will work as expected if swap 2 LOC:

$result = $validator->validate($data);
$values = $filter->filter($result->getValues());

=>

$filteredInput = $filter->filter($data);
$result = $validator->validate($filteredInput);

So not even Slug filter changes required. Everything works as expected with correct usual workflow.