Redesign navigation

[mvahowe]

Right now we have a quirky accordion down the left hand side of the card. As a first step to fixing this we could add a chapter picker at the top, as for the other editors. We can then remove at least one layer of the accordion.

@Le-rg-o I think we had a plan for the rest of this but I can't see it in github.

[Le-rg-o]

One step in the right direction is to move the Add button out of the toolbar and add it to the editor card itself.
On top of that, when the BCV document is empty (without any notes), the form is not displayed. As shown below on the left 👇

[Le-rg-o]

Here is a broad idea. Details should still be discussed, ask if any doubt.
Link to those mock-ups.

[mvahowe]

The PR above is going in a good direction. For next steps after that PR...

What we do about chapters/verses needs more thought.

• There's typically a "chapter 'intro'" which contains a book introduction. We can handle that in the menu fairly easily.
• There's often also a "verse 'intro'" which contains notes for a whole chapter. Again, that feels easy to handle.
• Less obviously, there are notes on a range of verses, eg "verse 1-4". In some cases these may span chapters, one classic example being a section note on Genesis 1 that ends a few verses into Genesis 2. And such notes may not nest cleanly, ie there might be GEN 1:1-2:3 and GEN 2 and you can't put either inside the other. If you're looking at a verse, you probably want any note that includes your verse, and we already do that in many places. If you're editing, you probably don't want to see the same note while looking at 30 different verses. So, for the editor, maybe we attach GEN 1:1-2:3 to GEN 1:1? And if we do that, maybe we should show the range in the menu, eg
  • v1
    • note1
    • note2 (1:1-2:4)
    • note 3

[Le-rg-o]

I don't think a note about a range should be only on the first item of that range (if I understood correctly). We cannot expect users start working on a range by the first item 100% of the time. And even if we expected that, we can't expect them to remember after 10 items that they are still in a range.
I would either do:

• The range note is visible in each verse in that range. Yes you have repetition, but it's not a problem. It's indeed interesting to have a way to quickly distinguish those notes (with the (1:1-2:4)).
• There's a "Range notes" accordion below the Introductions one.

[mvahowe]

@eliaspinero Thanks for the chapter picker!

Another obvious thing is to not show an empty, disabled form when there are no notes for a given book. Could we instead show a message like "No notes found" / "Aucune note trouvée", vertically and horizontally centred where the disabled form currently goes?

[mvahowe]

@Le-rg-o The task I'm thinking of is revising notes. You want to visit each note exactly once. Requiring the user to work out which notes she has already seen doesn't feel like a feature. You typically want to keep clicking forward until you get to the end.