PropertyDescriptor are gathered in an indeterministic way

[tchegito]

Great lib which really improves java.beans.Introspector performance (30 seconds instead of 100 seconds in my current case).

But I noticed that as introspection is done, the result is not always the same. Sometimes, instead of having a propertyDescriptor like that:

[name=foo
readMethod=getFoo,
writeMethod=setFoo]

I receive:

[[name=foo
readMethod=null,
writeMethod=setFoo],
[name=foo
readMethd=getFoo,
writeMethod=null]]

I don't get why the behavior is not constant, though you implemented a field comparator which should handle properties always in the same order, but it actually happens !

[mambastudio]

Great lib which really improves java.beans.Introspector performance (30 seconds instead of 100 seconds in my current case).

But I noticed that as introspection is done, the result is not always the same. Sometimes, instead of having a propertyDescriptor like that:

[name=foo readMethod=getFoo, writeMethod=setFoo]

I receive:

[[name=foo readMethod=null, writeMethod=setFoo], [name=foo readMethd=getFoo, writeMethod=null]]

I don't get why the behavior is not constant, though you implemented a field comparator which should handle properties always in the same order, but it actually happens !

Were you able to resolve this? Getting a similar problem.

[mambastudio]

Great lib which really improves java.beans.Introspector performance (30 seconds instead of 100 seconds in my current case).
But I noticed that as introspection is done, the result is not always the same. Sometimes, instead of having a propertyDescriptor like that:
[name=foo readMethod=getFoo, writeMethod=setFoo]
I receive:
[[name=foo readMethod=null, writeMethod=setFoo], [name=foo readMethd=getFoo, writeMethod=null]]
I don't get why the behavior is not constant, though you implemented a field comparator which should handle properties always in the same order, but it actually happens !

Were you able to resolve this? Getting a similar problem.

I think I managed to solve the issue. The problem is the sorting method of the FieldOrderComparator in the Introspector.

java-beans-lite/src/main/java/lite/beans/Introspector.java

Lines 97 to 108 in 0efa11a

	public int compare(String o1, String o2) {
	int index1 = order.indexOf(o1);
	int index2 = order.indexOf(o2);
	if(index1 == -1) {
	if(index2 == -1) {
	return o1.compareTo(o2);
	} else {
	return 1;
	}
	}
	return index1 - index2;
	}

I don't understand why it should return 1 when doing the index == -1, but removing resolved the issue. The new code should be...

public int compare(String o1, String o2) { 
     int index1 = order.indexOf(o1); 
     int index2 = order.indexOf(o2); 
     if(index1 == -1) { 
         if(index2 == -1) { 
             return o1.compareTo(o2);        
         } 
     } 
     return index1 - index2; 
 }

This resolved my problem.