Skip to content

Registry credentials PoC#436

Draft
AlexHardAtWork wants to merge 3 commits into
mainfrom
docs/165-registry-credentials-poc
Draft

Registry credentials PoC#436
AlexHardAtWork wants to merge 3 commits into
mainfrom
docs/165-registry-credentials-poc

Conversation

@AlexHardAtWork
Copy link
Copy Markdown
Contributor

@AlexHardAtWork AlexHardAtWork commented Apr 21, 2026

PoC implementation of #401, should be recycled in #402

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 21, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c1437aa8-ce22-4368-b337-2e7655e62fdb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/165-registry-credentials-poc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 21, 2026

Coverage Report for CI Build 24822429227

Coverage decreased (-0.5%) to 72.505%

Details

  • Coverage decreased (-0.5%) from the base build.
  • Patch coverage: 22 uncovered changes across 4 files (190 of 212 lines covered, 89.62%).
  • 41 coverage regressions across 2 files.

Uncovered Changes

File Changed Covered %
pkg/controller/target_controller.go 77 64 83.12%
pkg/controller/helpers.go 10 6 60.0%
pkg/controller/resolve.go 107 104 97.2%
pkg/controller/rendertask_controller.go 14 12 85.71%

Coverage Regressions

41 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
pkg/controller/target_controller.go 27 73.38%
pkg/controller/rendertask_controller.go 14 86.43%

Coverage Stats

Coverage Status
Relevant Lines: 2986
Covered Lines: 2165
Line Coverage: 72.51%
Coverage Strength: 34.18 hits per line

💛 - Coveralls

@AlexHardAtWork AlexHardAtWork force-pushed the docs/165-registry-credentials-poc branch from ca7dc88 to 4275ff7 Compare April 23, 2026 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants