Skip to content

feat: update resource version when helm chart version is bumped#69

Merged
olzemal merged 3 commits into
mainfrom
feat/update-vesion-helm
May 22, 2026
Merged

feat: update resource version when helm chart version is bumped#69
olzemal merged 3 commits into
mainfrom
feat/update-vesion-helm

Conversation

@yocaba
Copy link
Copy Markdown
Contributor

@yocaba yocaba commented May 21, 2026

What

Like #45 but for helm charts.

Why

The resource version is not updated when the helm chart is bumped. They should be in sync. See https://github.com/opendefensecloud/ocm-components/pull/62/changes

Testing

none

Checklist

  • Tests added/updated n/a
  • No breaking changes (or upgrade path documented above)
  • Readable commit history (squashed and cleaned up as desired)
  • AI code review considered and comments resolved

Summary by CodeRabbit

  • Chores
    • Updated Helm chart version extraction configuration to use an improved parsing strategy for better version recognition and normalization.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 883652a5-7bf9-4ace-b1e0-7d778c157974

📥 Commits

Reviewing files that changed from the base of the PR and between 1431abd and 8396e5e.

📒 Files selected for processing (1)
  • renovate.json

📝 Walkthrough

Walkthrough

This PR updates the renovate.json configuration to migrate the Helm chart custom manager from regex-based matching to JSONata-based matching. The new configuration extracts chart names and registry URLs using JSONata expressions and adds version normalization via an extractVersion pattern.

Changes

Helm chart custom manager JSONata migration

Layer / File(s) Summary
Helm chart custom manager JSONata configuration
renovate.json
The helmChart custom manager switches from regex-based customType to jsonata customType with new matchStrings expressions that extract depName from access.helmChart, currentValue from split fields, and registryUrl from access.helmRepository. An extractVersion pattern is added to strip leading v from version strings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A config of Helm takes a JSONata turn,
Regex laid aside, new patterns we learn,
Version strings trimmed of their leading 'v' grace,
Registry URLs find their rightful place! 🎯

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating resource version when Helm chart version is bumped, which aligns with the renovate.json configuration changes.
Description check ✅ Passed The description follows the template with all required sections present (What, Why, Testing, Checklist), though testing section states 'none' and includes helpful context with PR references.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/update-vesion-helm

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yocaba
Copy link
Copy Markdown
Contributor Author

yocaba commented May 21, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@yocaba yocaba marked this pull request as ready for review May 21, 2026 13:56
@yocaba yocaba requested a review from olzemal May 22, 2026 10:09
olzemal
olzemal previously approved these changes May 22, 2026
Copy link
Copy Markdown
Contributor

@olzemal olzemal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on https://try.jsonata.org , lgtm

@olzemal olzemal merged commit e5e5264 into main May 22, 2026
1 check passed
@olzemal olzemal deleted the feat/update-vesion-helm branch May 22, 2026 11:51
@coderabbitai coderabbitai Bot mentioned this pull request May 22, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants