fix: renovate for github runners#67
Conversation
📝 WalkthroughWalkthroughRenovate configuration now includes a custom manager that detects GitHub Actions runner specifications in workflow ChangesGitHub Actions Runner Version Management
🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
renovate.json (1)
54-54: ⚡ Quick winBroaden the
runs-onregex to cover quoted and suffixed runner labels.Current pattern can miss common workflow forms like
runs-on: "ubuntu-24.04"andruns-on: ubuntu-24.04-arm, which limits update coverage.Proposed diff
- "runs-on:\\s*(?<depName>\\w+)-(?<currentValue>[\\d.]+)" + "runs-on:\\s*[\"']?(?<depName>[A-Za-z][A-Za-z-]*)-(?<currentValue>\\d+(?:\\.\\d+){1,2})(?:-[A-Za-z0-9_-]+)?[\"']?"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@renovate.json` at line 54, The current regex string "runs-on:\s*(?<depName>\w+)-(?<currentValue>[\d.]+)" is too narrow; update that value in renovate.json to allow optional surrounding quotes and optional hyphenated suffixes (like -arm) after the version. Replace the pattern so it accepts an optional quote before/after the whole runner label, keeps the named groups depName and currentValue, and permits extra -suffix segments after the numeric version (e.g., use optional ["']? and a non-capturing (?:-[\w-]+)? for suffixes while preserving (?<depName>\w+) and (?<currentValue>[\d.]+)).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@renovate.json`:
- Line 54: The current regex string
"runs-on:\s*(?<depName>\w+)-(?<currentValue>[\d.]+)" is too narrow; update that
value in renovate.json to allow optional surrounding quotes and optional
hyphenated suffixes (like -arm) after the version. Replace the pattern so it
accepts an optional quote before/after the whole runner label, keeps the named
groups depName and currentValue, and permits extra -suffix segments after the
numeric version (e.g., use optional ["']? and a non-capturing (?:-[\w-]+)? for
suffixes while preserving (?<depName>\w+) and (?<currentValue>[\d.]+)).
What
Enables Renovate for Github Runners.
Part of #odd-internal/28.
Why
Runners need updates.
Testing
Not tested.
Notes for reviewers
...
Checklist
Summary by CodeRabbit