Skip to content

fix: renovate for github runners#67

Merged
AlexHardAtWork merged 1 commit into
mainfrom
chore/28-renovate-github-runners
May 21, 2026
Merged

fix: renovate for github runners#67
AlexHardAtWork merged 1 commit into
mainfrom
chore/28-renovate-github-runners

Conversation

@AlexHardAtWork
Copy link
Copy Markdown
Contributor

@AlexHardAtWork AlexHardAtWork commented May 20, 2026

What

Enables Renovate for Github Runners.

Part of #odd-internal/28.

Why

Runners need updates.

Testing

Not tested.

Notes for reviewers

...

Checklist

  • Tests added/updated
  • No breaking changes (or upgrade path documented above)
  • Readable commit history (squashed and cleaned up as desired)
  • AI code review considered and comments resolved

Summary by CodeRabbit

  • Chores
    • Enhanced dependency management configuration to better support GitHub Actions runner updates, enabling automatic detection and tracking of runner versions across workflows.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

📝 Walkthrough

Walkthrough

Renovate configuration now includes a custom manager that detects GitHub Actions runner specifications in workflow runs-on fields, extracts the runner label and version information via regex, and applies version updates from the github-runners datasource using Docker versioning.

Changes

GitHub Actions Runner Version Management

Layer / File(s) Summary
Custom manager for GitHub Actions runner version tracking
renovate.json
Added a regex-based customManagers entry that matches workflow runs-on patterns to extract runner names and versions, routing updates through the github-runners datasource with docker versioning.

🎯 2 (Simple) | ⏱️ ~10 minutes

🐰 A runner hops into the config,
Its version tagged with docker's magic,
Renovate now keeps it fresh and spry,
With regex patterns that don't pass by!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding Renovate support for GitHub Runners to the renovate.json configuration.
Description check ✅ Passed The description covers main sections but lacks sufficient detail in critical areas; 'Testing: Not tested' and sparse reviewer notes are concerning.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/28-renovate-github-runners

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yocaba
Copy link
Copy Markdown
Contributor

yocaba commented May 21, 2026

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
renovate.json (1)

54-54: ⚡ Quick win

Broaden the runs-on regex to cover quoted and suffixed runner labels.

Current pattern can miss common workflow forms like runs-on: "ubuntu-24.04" and runs-on: ubuntu-24.04-arm, which limits update coverage.

Proposed diff
-        "runs-on:\\s*(?<depName>\\w+)-(?<currentValue>[\\d.]+)"
+        "runs-on:\\s*[\"']?(?<depName>[A-Za-z][A-Za-z-]*)-(?<currentValue>\\d+(?:\\.\\d+){1,2})(?:-[A-Za-z0-9_-]+)?[\"']?"
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@renovate.json` at line 54, The current regex string
"runs-on:\s*(?<depName>\w+)-(?<currentValue>[\d.]+)" is too narrow; update that
value in renovate.json to allow optional surrounding quotes and optional
hyphenated suffixes (like -arm) after the version. Replace the pattern so it
accepts an optional quote before/after the whole runner label, keeps the named
groups depName and currentValue, and permits extra -suffix segments after the
numeric version (e.g., use optional ["']? and a non-capturing (?:-[\w-]+)? for
suffixes while preserving (?<depName>\w+) and (?<currentValue>[\d.]+)).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@renovate.json`:
- Line 54: The current regex string
"runs-on:\s*(?<depName>\w+)-(?<currentValue>[\d.]+)" is too narrow; update that
value in renovate.json to allow optional surrounding quotes and optional
hyphenated suffixes (like -arm) after the version. Replace the pattern so it
accepts an optional quote before/after the whole runner label, keeps the named
groups depName and currentValue, and permits extra -suffix segments after the
numeric version (e.g., use optional ["']? and a non-capturing (?:-[\w-]+)? for
suffixes while preserving (?<depName>\w+) and (?<currentValue>[\d.]+)).

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e1451d80-e36d-427c-a6f9-d32a9b1667e9

📥 Commits

Reviewing files that changed from the base of the PR and between 004b4d2 and f43d948.

📒 Files selected for processing (1)
  • renovate.json

@AlexHardAtWork AlexHardAtWork merged commit 264f0e8 into main May 21, 2026
2 checks passed
@AlexHardAtWork AlexHardAtWork deleted the chore/28-renovate-github-runners branch May 21, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants