Menue not working

[Bernd37429]

I try to make a menue which is showing rpm value in the main form and in a second form I'd like to change velocity and acceleration value as min max field each.
Based on StopWatch example my code looks like this:

#include <U8g2lib.h>
#include <MUIU8g2.h>
#include <SimpleRotary.h>
// https://github.com/mprograms/SimpleRotary
const uint8_t clk = PA0;   // Uno: 2;
const uint8_t dt = PA1;    // Uno: 3;
const uint8_t sw = PA2;  // Uno: 4;
SimpleRotary rotary(clk, dt, sw);

// U8g2 Constructor
// STM32 SDA: PB7, SCL: PB6; Uno SDA: , SCL;
U8G2_SH1107_128X128_1_HW_I2C u8g2(U8G2_R1, /* reset=*/ U8X8_PIN_NONE);

MUIU8G2 mui;

/*=================================================*/
volatile uint8_t p1;
volatile uint8_t p2;

long currentRPM = 0;          // rpm value
uint8_t isRotRunning = 1;     // defines the current state of the rpm watch: running or not running

/* draw the current stop watch value */
uint8_t mui_draw_current_rpm(mui_t *ui, uint8_t msg) {
  if (msg == MUIF_MSG_DRAW) {
      currentRPM = analogRead(A0);
      u8g2.setCursor(mui_get_x(ui), mui_get_y(ui));
      u8g2.print(currentRPM);
  }
  return 0;
}

/* start the rpm display */
uint8_t mui_start_current_rpm(mui_t *ui, uint8_t msg) {
  if ( msg == MUIF_MSG_FORM_START ) {
      isRotRunning = 1;
  }
  return 0;
}

/* stop the stop watch rpm */
uint8_t mui_stop_current_rpm(mui_t *ui, uint8_t msg) {
  if ( msg == MUIF_MSG_FORM_END )
      isRotRunning = 0;
  return 0;
}

/*=================================================*/
/* muif */

muif_t muif_list[]   = {  
  MUIF_U8G2_FONT_STYLE(0, u8g2_font_helvR08_tr), 
  MUIF_U8G2_FONT_STYLE(1, u8g2_font_helvB08_tr),        /* bold font */
  MUIF_U8G2_FONT_STYLE(3, u8g2_font_fub35_tn), 
  /* MUI_LABEL is used to place fixed text on the screeen */
  MUIF_U8G2_LABEL(),
  /* custom MUIF callback to draw the current rpm value */
  MUIF_RO("CR", mui_draw_current_rpm),
  /* stop rpm display when leaving form 1*/
  MUIF_RO("SO", mui_stop_current_rpm),
  /* stop rpm display when leaving form 1*/
  MUIF_RO("ST", mui_start_current_rpm),
  
  MUIF_BUTTON("GO", mui_u8g2_btn_goto_wm_fi),
  
  MUIF_U8G2_U8_MIN_MAX("P1", (uint8_t *)&p1, 0, 255, mui_u8g2_u8_min_max_wm_mud_pi),
  MUIF_U8G2_U8_MIN_MAX("P2", (uint8_t *)&p2, 0, 255, mui_u8g2_u8_min_max_wm_mud_pi)
};

/*=================================================*/
/* fields and forms... */

fds_t fds_data[]   =
// Main Menu
MUI_FORM(1)
MUI_STYLE(1)
MUI_AUX("SO")                      // this will stop
MUI_AUX("ST")                      // this will start
MUI_LABEL(2, 60, "rpm")
MUI_STYLE(3)
// MUI_AUX("ST")            // this will start the rpm display once this form is entered
MUI_XY("CR", 15, 40)
MUI_STYLE(0)
MUI_XYAT("GO", 70, 60, 2, "Edit Params")

// Edit param form
MUI_FORM(2)
MUI_STYLE(0)
MUI_LABEL(2, 10, "Param1")
MUI_XY("P1", 45, 10)
MUI_LABEL(2, 30, "Param2")
MUI_XY("P2", 45, 30)

MUI_XYAT("GO", 63, 50, 1, "Back")
;

/*=================================================*/
/* event loop and Arduino main part */

// global variables for menu redraw and input event handling
uint8_t is_redraw = 1;

void setup(void) {
  u8g2.begin();
  mui.begin(u8g2, fds_data, muif_list, sizeof(muif_list)/sizeof(muif_t));
  mui.gotoForm(/* form_id= */ 1, /* initial_cursor_position= */ 0);
}

uint8_t rotary_event = 0; // 0 = not turning, 1 = CW, 2 = CCW
uint8_t push_event = 0; // 0 = not pushed, 1 = pushed

void check_events(void) {
  uint8_t tmp;
  
  // 0 = not pushed, 1 = pushed  
  tmp = rotary.push();
  if ( tmp != 0 )         // only assign the push event, never clear the event here
    push_event = tmp;
    
  // 0 = not turning, 1 = CW, 2 = CCW
  tmp = rotary.rotate();
  if ( tmp != 0 )       // only assign the rotation event, never clear the event here
    rotary_event = tmp;    
}

void handle_events(void) {
  // 0 = not pushed, 1 = pushed  
  if ( push_event == 1 ) {
      mui.sendSelect();
      is_redraw = 1;
      push_event = 0;
  }
  
  // 0 = not turning, 1 = CW, 2 = CCW
  if ( rotary_event == 1 ) {
    mui.nextField();
    is_redraw = 1;
    rotary_event = 0;
  }
  
  if ( rotary_event == 2 ) {
    mui.prevField();
    is_redraw = 1;
    rotary_event = 0;
  }    
}

void loop(void) {

  /* check whether the menu is active */
  if ( mui.isFormActive() ) {

    /* update the display content, if the redraw flag is set */
    if (is_redraw) {
      u8g2.firstPage();
      do {
          check_events();
          mui.draw();
          check_events();
        } while( u8g2.nextPage() );
      is_redraw = 0;                    /* clear the redraw flag */
    }

    check_events();   // check for button press with bounce2 library
    handle_events();  // process events from bounce2 library
	
	if ( is_redraw == 0 && mui.getCurrentFormId() == 1 )  {
      is_redraw = 1;      /* keep doing a redraw, because we want some animation */
    }
  
  } else {
      /* the menu should never become inactive, but if so, then restart the menu system */
      mui.gotoForm(/* form_id= */ 1, /* initial_cursor_position= */ 0);
  }
}

Unfortunately the second form doesnt't work at all.
Any ideas?
Thanks in advance.
Bernd

[olikraus]

What exactly doesn't work?
Will the form work if you jump to form 2 in the setup function?

[Bernd37429]

Sorry for beeing not precise enough.
Yes, the only thing I can do in the second form is to select and unselect the first field. But neither incrementing or decrementing the value, nor selecting the second parameter or the back button works.

And yes, if I jump directly to form 2 in the setup function, the form works pretty well. Exactly how I wanted to do it.
Back to form 1 and again to form 2 destroys something I dont understand, and form 2 again doesnt work.

Thanks for any hint

[Bernd37429]

As you might see in the Rotary declaration const uint8_t clk = PA0; I'm currently using a Bluepill MCU, where the display is connected to SDA: PB7, SCL: PB6; Just to avoid level shifter for the OLED display and getting more RAM. Maybe these ports cause the trouble?
I just tested my program on an Arduino Nano, Rotary encoder connected to port D2,D3,D4, display to A4, A5. This constellation works pretty well, without any dead end.

[olikraus]

hmm.. from my perspective the code looks good. I can not say much about specific uC hardware problems, but maybe you can just use the Arduino console to print out some debug info to check whether your buttons and rotary encoder works as expected.

[Bernd37429]

If I would know what to debug this should be no problem.
The MUIInputSimpleRotary.ino example works without problems with the STM32F103C8T6 in the same configuration. So I thought the problem lies in my code.
Is there any trace option for mui internals? I thought I have read somewhere about tracing program flow of mui.
I tested my program with the VersatileRotaryEncoder library. Unfortunately with the same effect, The second frame doesn't do anything execept toggeling the first MinMax field, but not changing numbers, not jumping to any next field.

[olikraus]

For debugging: You could use the usual serial out from Arduino env if this works for your uC
I personally implement the code in the SDL environment: https://github.com/olikraus/u8g2/tree/master/sys/sdl
Drawback of SDL: Only the C interface is available.

[Bernd37429]

Thank you for trying to help me! Unfortunatly I never heard about SDL. Google told me SDL is Simple DirectMedia Layer,a cross-platform development library. Im afraid to work with this library exceeds my abilities. Im not a programmer, miles away to create such cool libraries like u8g2, mui like you. Im just an interested hobbyist, trained mechatronics engineer.
Debugging is not the problem, with STM32 bluepill you have got a JTAG/SWD Interface over ST-LinkV2 hardware.

Im afraid I might not understand the underlying mui interface and so I really dont know where to start debugging.
Sorry

[Bernd37429]

What I tried now is to modify push_event and rotary_event. Actually the field p1 and p2 got modified, even if I changed mutiple times to form1 and back. But why only in debug mode? I have no plan...

[olikraus]

so you are saying it works in debug mode but not in your standalone application?

If so, then indeed such bugs are really hard to find. Unfortunately i don't have your environment, so helping here difficult.
I think looking at the events is the right approach.

[Bernd37429]

Yes it worked in debug mode, but I had to enter the rotary_event and push_event variables directly via debugger.
If you have time and are willing to help me I can send you a Bluepill MCU.
Should be no problem, I do live in Germany like you.

[olikraus]

but I had to enter the rotary_event and push_event variables directly via debugger.

ah, ok, but this doesn't sound like u8g2 problem.

If you have time and are willing to help me I can send you a Bluepill MCU.

time is the limiting factor here... currently I am not able to spend more than 30min / week on u8g2