Skip to content

Variable with spaces fails deploy because of incorrect --var transformation #61

@viddo

Description

@viddo

STR

Define some variables containing spaces, e.g.

with:
  variables: FOO="bar baz",OTHER=…

Expected results

Variables applied like --var FOO="bar baz" --var OTHER=…

Actual results

Deploy fails with error like so (redacted irrelevant parts):

running: <preview-name> … --var FOO="bar --var baz" --var OTHER=…
 i  Using <ns> @ <domain> as context
 x  Invalid variable value 'baz"': must follow KEY=VALUE format

Observations

This appears to happen because the variables are incorrectly split:

variable_params= --var FOO=bar
variable_params= --var baz
variable_params= --var OTHER=…

I believe the culprit area is where the variables are split up into the separate --var KEY=VALUE args, here:

variable_params=""
if [ ! -z "${variables}" ]; then
for ARG in $(echo "${variables}" | tr ',' '\n'); do
variable_params="${variable_params} --var ${ARG}"
done
params="${params} $variable_params"
fi

Also tried with single quotes instead, same err.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions