Compile errors on player build with Unity 2019

[bgr]

Can't build player on 2019.4.40:

The type or namespace name 'RuntimeInternals' does not exist in the namespace 'TestHelper' (are you missing an assembly reference?)

coming from 4 scripts FocusGameViewAttribute.cs(8,18), GameViewResolutionAttribute.cs(8,18), GizmosShowOnGameViewAttribute.cs(8,18), LoadSceneAttribute.cs(9,18), TakeScreenshotAttribute.cs(8,18).

Adding scripting define symbols COM_NOWSPRINTING_TEST_HELPER_ENABLE and/or UNITY_INCLUDE_TESTS causes the following compile error:

ArgumentException: The Assembly UnityEngine.TestRunner is referenced by TestHelper ('Library/PlayerScriptAssemblies/TestHelper.dll'). But the dll is not allowed to be included or could not be found.

How is the library supposed to be used in a project that will also need to make a regular player build of the game?

[nowsprinting]

If you are using ScreenshotHelper and/or SceneManagerHelper, you must add TestHelper.RuntimeInternals to the "Assembly Definition References" in your game's asmdef.

And do NOT add TestHelper in your game's asmdef. Add to only test assembly.

[bgr]

I'm not using those, you can reproduce the problem by making a new project in 2019.4 and adding the package via Package Manager > Add from git URL > https://github.com/nowsprinting/test-helper.git and trying to build.

[nowsprinting]

This seems to be a problem with Unity 2019. test-framework is enabled in the player build with Unity 2019.
The same issue occurs with the New Input System package (com.unity.inputsystem).

I will look into a workaround, but upgrading your project to Unity 2020 or higher is the easiest one.

[bgr]

It's worth noting that before I discovered the problem with the build, I was able to successfully use the LoadScene attribute and have the tests run in the built player (ran from the Test Runner). I saw in package.json that minimum version is 2019.4, our project is stuck on that version for now due to various 3rd party dependencies preventing us from upgrading without significant effort.