Performance degradation when use with tsconfig-paths after require-in-the-middle@7.5.0

[pilaoda]

seems caused by tsconfig-paths override Module._resolveFilename
https://github.com/dividab/tsconfig-paths/blob/098e066632f5b9f35c956803fe60d17ffc60b688/src/register.ts#L106

nodejs builtin resolve will call Module._resolveFilename again. This behavior introduced in #96.

require-in-the-middle/index.js

Line 75 in f7b7853

return require.resolve(moduleName, { paths: [basedir] })

Maybe we can provide a config or environment variable to force use require('resolve').sync() ?

[timfish]

The plan is to remove resolve entirely as a dependency in the next major since it is not required in any version of node >= v8.10.0

• feat!: Remove dependency on resolve module #104

[pilaoda]

The plan is to remove resolve entirely as a dependency in the next major since it is not required in any version of node >= v8.10.0

• feat!: Remove resolve dependency which increases min Node version to v8.10.0 #104

Sad.
Then we'll be forced to choose between require-in-the-middle@7.5+ and tsconfig-paths.
Do you have any good suggestions?

[timfish]

resolve brings in a lot of dependencies that aren't used by everyone using Node >= 8.10.0 (which is likely almost everyone using require-in-the-middle):

Do you have any good suggestions?

Not currently because I don't fully understand the issue and why it causes performance degradation!

[pilaoda]

For each require, @7.5 may run Module._resolveFilename twice, then it run the tsconfig-paths patched Module._resolveFilename twice.

require-in-the-middle/index.js

Line 222 in f7b7853

filename = Module._resolveFilename(id, this)

require-in-the-middle/index.js

Line 323 in f7b7853

res = resolve(moduleName, basedir)

[timfish]

Can you check if this issue has been fixed by the latest major?

resolve has now been completely removed as a dependency!

[pilaoda]

Can you check if this issue has been fixed by the latest major?

resolve has now been completely removed as a dependency!

The problem is not the npm resolve dependency.
It's the nodjes builtin require.resolve cause the problem.

It call the heavy patched Module._resolveFilename again.
https://github.com/nodejs/node/blob/875a7bb8d28e4079a8f8668e4962d32fb19a7c56/lib/internal/modules/helpers.js#L163