refactor: remove select dual states #9019
araujoguilint-and-tests.yml
on: pull_request
Quality checks
54s
Tests
1m 10s
Annotations
6 errors, 2 warnings, and 3 notices
|
Quality checks
Process completed with exit code 1.
|
|
Quality checks
@node-core/ui-components#lint: command (/home/runner/work/nodejs.org/nodejs.org/packages/ui-components) /home/runner/setup-pnpm/node_modules/.bin/pnpm run lint exited (1)
|
|
Quality checks:
packages/ui-components/src/Common/Select/index.stories.tsx#L114
React Hook "useArgs" is called in function "render" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter. React Hook names must start with the word "use"
|
|
Tests
Process completed with exit code 1.
|
|
Tests
@node-core/ui-components#test:unit: command (/home/runner/work/nodejs.org/nodejs.org/packages/ui-components) /home/runner/setup-pnpm/node_modules/.bin/pnpm run test:unit exited (1)
|
|
renders the default value when provided:
packages/ui-components/packages/ui-components/src/Common/Select/__tests__/index.test.jsx#L50
Error [TestingLibraryElementError]: Unable to find an element with the text: Option 1. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.
Ignored nodes: comments, script, style
<body>
<div>
<span
class=""
>
<label
for="_r_6_"
>
Option label
</label>
<button
aria-autocomplete="none"
aria-controls="radix-_r_7_"
aria-expanded="false"
class=""
data-placeholder=""
data-state="closed"
dir="ltr"
id="_r_6_"
role="combobox"
type="button"
>
<span
style="pointer-events: none;"
>
Select an option
</span>
<svg
aria-hidden="true"
data-slot="icon"
fill="none"
stroke="currentColor"
stroke-width="1.5"
viewBox="0 0 24 24"
xmlns="http://www.w3.org/2000/svg"
>
<path
d="m19.5 8.25-7.5 7.5-7.5-7.5"
stroke-linecap="round"
stroke-linejoin="round"
/>
</svg>
</button>
</span>
</div>
</body>
at Object.getElementError (/home/runner/work/nodejs.org/nodejs.org/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@testing-library/dom/dist/config.js:37:19)
at /home/runner/work/nodejs.org/nodejs.org/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@testing-library/dom/dist/query-helpers.js:76:38
at /home/runner/work/nodejs.org/nodejs.org/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@testing-library/dom/dist/query-helpers.js:52:17
at /home/runner/work/nodejs.org/nodejs.org/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@testing-library/dom/dist/query-helpers.js:95:19
at TestContext.<anonymous> (/home/runner/work/nodejs.org/nodejs.org/packages/ui-components/src/Common/Select/__tests__/index.test.jsx:50:12)
at Test.runInAsyncScope (node:async_hooks:228:14)
at Test.run (node:internal/test_runner/test:1118:25)
at Suite.processPendingSubtests (node:internal/test_runner/test:787:18)
at Test.postRun (node:internal/test_runner/test:1247:19)
at Test.run (node:internal/test_runner/test:1175:12)
|
|
Quality checks
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda, step-security/harden-runner@f4a75cfd619ee5ce8d5b864b0d183aff3c69b55a. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Tests
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea, pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda, step-security/harden-runner@f4a75cfd619ee5ce8d5b864b0d183aff3c69b55a. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Tests
Total Tests: 35
Suites 📂: 15
Passed ✅: 34
Failed ❌: 1
Canceled 🚫: 0
Skipped ⏭️: 0
Todo 📝: 0
Duration 🕐: 18704.060ms
|
|
Tests
Total Tests: 58
Suites 📂: 9
Passed ✅: 58
Failed ❌: 0
Canceled 🚫: 0
Skipped ⏭️: 0
Todo 📝: 0
Duration 🕐: 1733.532ms
|
|
Tests
Total Tests: 4
Suites 📂: 4
Passed ✅: 4
Failed ❌: 0
Canceled 🚫: 0
Skipped ⏭️: 0
Todo 📝: 0
Duration 🕐: 453.953ms
|