From d641fb305fc3f0edb3cc29e12f96289c2a589442 Mon Sep 17 00:00:00 2001 From: James M Snell Date: Mon, 30 Mar 2026 09:06:23 -0700 Subject: [PATCH 1/2] meta: require DCO signoff in commit message guidelines --- doc/contributing/pull-requests.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/doc/contributing/pull-requests.md b/doc/contributing/pull-requests.md index b2556577536791..7001ac68cbdf46 100644 --- a/doc/contributing/pull-requests.md +++ b/doc/contributing/pull-requests.md @@ -199,6 +199,12 @@ A good commit message should describe what changed and why. contain an explanation about the reason of the breaking change, which situation would trigger the breaking change, and what is the exact change. +6. Your commit must contain the `Signed-off-by` line with your name and email + address as an acknowledgement that you agree to the [Developer Certificate of Origin][]. + Bot generated commits are exempt from this requirement. If a commit has + multiple authors, the `Signed-off-by` line should be added for each author; + and at least one should match the author information in the commit metadata. + Sample complete commit message: ```text @@ -210,6 +216,7 @@ less. Fixes: https://github.com/nodejs/node/issues/1337 Refs: https://eslint.org/docs/rules/space-in-parens.html +Signed-off-by: J. Random User ``` If you are new to contributing to Node.js, please try to do your best at @@ -594,6 +601,7 @@ More than one subsystem may be valid for any particular issue or pull request. [Building guide]: ../../BUILDING.md [CI (Continuous Integration) test run]: #continuous-integration-testing [Code of Conduct]: https://github.com/nodejs/admin/blob/HEAD/CODE_OF_CONDUCT.md +[Developer Certificate of Origin]: ../../CONTRIBUTING.md#developers-certificate-of-origin-11 [Onboarding guide]: ../../onboarding.md [approved]: #getting-approvals-for-your-pull-request [benchmark results]: writing-and-running-benchmarks.md From 804006bfda8f127fe504a6632f9192dedc81e2b7 Mon Sep 17 00:00:00 2001 From: James M Snell Date: Mon, 30 Mar 2026 13:32:26 -0700 Subject: [PATCH 2/2] Apply suggestion from @jasnell --- doc/contributing/pull-requests.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/contributing/pull-requests.md b/doc/contributing/pull-requests.md index 7001ac68cbdf46..9118374a95319f 100644 --- a/doc/contributing/pull-requests.md +++ b/doc/contributing/pull-requests.md @@ -204,6 +204,8 @@ A good commit message should describe what changed and why. Bot generated commits are exempt from this requirement. If a commit has multiple authors, the `Signed-off-by` line should be added for each author; and at least one should match the author information in the commit metadata. + This rule does not apply to dependency updates (e.g. cherry-picks), release + commits, or backport commits. Sample complete commit message: