test_runner: print Bailout for spec reporter

Author: pmarchini

lib/internal/test_runner/reporter/spec.js

@@ -78,6 +78,8 @@ class SpecReporter extends Transform {
   }
   #handleEvent({ type, data }) {
     switch (type) {
+      case 'test:bail':
+        return `${reporterColorMap['test:bail']}Bailing out! no new test files will be started!${colors.white}\n`;
       case 'test:fail':
         if (data.details?.error?.failureType !== kSubtestsFailed) {
           ArrayPrototypePush(this.#failedTests, data);

lib/internal/test_runner/reporter/utils.js

@@ -37,6 +37,9 @@ const reporterColorMap = {
   get 'test:diagnostic'() {
     return colors.blue;
   },
+  get 'test:bail'() {
+    return colors.yellow;
+  },
   get 'info'() {
     return colors.blue;
   },

lib/internal/test_runner/runner.js

@@ -257,16 +257,6 @@ class FileTest extends Test {
       item.data.details.error = deserializeError(item.data.details.error);
     }
 
-    if (item.type === 'test:fail' && this.root.harness.bail && !this.root.harness.bailedOut) {
-      // Trigger bail if enabled and this is the first failure
-      this.root.harness.bailedOut = true;
-      this.reporter[kEmitMessage]('test:bail', {
-        __proto__: null,
-        file: this.name,
-        test: item.data,
-      });
-    }
-
     if (item.type === 'test:pass' || item.type === 'test:fail') {
       item.data.testNumber = isTopLevel ? (this.root.harness.counters.topLevel + 1) : item.data.testNumber;
       countCompletedTest({
@@ -855,6 +845,18 @@ function run(options = kEmptyObject) {
         }
       };
 
+      root.reporter.on('test:fail', (item) => {
+        if (root.harness.bail && !root.harness.bailedOut) {
+          process.nextTick(() => {
+            root.harness.bailedOut = true;
+            root.reporter[kEmitMessage]('test:bail', {
+              __proto__: null,
+              file: item.name,
+              test: item.data,
+            });
+          });
+        }
+      });
     } else {
       runFiles = () => {
         root.harness.bootstrapPromise = null;

test/fixtures/test-runner/bail/bail-test-2-fail.js

@@ -7,5 +7,5 @@ test('failing test 1', () => {
 });
 
 test('failing test 2', () => {
-  assert.strictEqual(3, 4, 'This test should also fail but might not run');
+  assert.strictEqual(3, 4, 'This test fails as well');
 });

test/fixtures/test-runner/output/bail_concurrency_1.js

@@ -0,0 +1,13 @@
+'use strict';
+const fixtures = require('../../../common/fixtures');
+const { spec } = require('node:test/reporters');
+const { run } = require('node:test');
+
+const files = [
+  fixtures.path('test-runner', 'bail', 'bail-test-1-pass.js'),
+  fixtures.path('test-runner', 'bail', 'bail-test-2-fail.js'),
+  fixtures.path('test-runner', 'bail', 'bail-test-3-pass.js'),
+  fixtures.path('test-runner', 'bail', 'bail-test-4-pass.js'),
+];
+
+run({ bail: true, concurrency: 1, files }).compose(spec).compose(process.stdout);

test/fixtures/test-runner/output/bail_concurrency_1.snapshot

@@ -0,0 +1,55 @@
+✔ test 1 passes (*ms)
+✔ test 2 passes (*ms)
+✖ failing test 1 (*ms)
+Bailing out! no new test files will be started!
+✖ failing test 2 (*ms)
+ℹ tests 4
+ℹ suites 0
+ℹ pass 2
+ℹ fail 2
+ℹ cancelled 0
+ℹ skipped 0
+ℹ todo 0
+ℹ duration_ms *
+
+✖ failing tests:
+
+*
+✖ failing test 1 (*ms)
+  AssertionError [ERR_ASSERTION]: This test should fail
+  
+  1 !== 2
+  
+      *
+      *
+      *
+      *
+      * {
+    generatedMessage: false,
+    code: 'ERR_ASSERTION',
+    actual: 1,
+    expected: 2,
+    operator: 'strictEqual',
+    diff: 'simple'
+  }
+
+*
+✖ failing test 2 (*ms)
+  AssertionError [ERR_ASSERTION]: This test fails as well
+  
+  3 !== 4
+  
+      *
+      *
+      *
+      *
+      *
+      *
+      * {
+    generatedMessage: false,
+    code: 'ERR_ASSERTION',
+    actual: 3,
+    expected: 4,
+    operator: 'strictEqual',
+    diff: 'simple'
+  }

test/test-runner/test-output-bail-spec-reporter.mjs

@@ -0,0 +1,10 @@
+// Test that the output of test-runner/output/bail_concurrency_1.js matches test-runner/output/bail_concurrency_1.snapshot
+import '../common/index.mjs';
+import * as fixtures from '../common/fixtures.mjs';
+import { spawnAndAssert, specTransform, ensureCwdIsProjectRoot } from '../common/assertSnapshot.js';
+
+ensureCwdIsProjectRoot();
+await spawnAndAssert(
+  fixtures.path('test-runner/output/bail_concurrency_1.js'),
+  specTransform,
+);