stream: simplify eos immediate completion path

Author: ikeyan

lib/internal/streams/end-of-stream.js

@@ -183,19 +183,6 @@ function eos(stream, options, callback) {
   } else if ((rState && stream.req && stream.aborted)) {
     immediateResult = getEosErrored(stream);
   }
-  const returnImmediately = (result) => {
-    const args = result === null ? [] : [result];
-    if (options[kEosNodeSyncronousCallback]) {
-      callback.call(stream, ...args);
-    } else {
-      if (AsyncContextFrame.current() || enabledHooksExist()) {
-        // Avoid AsyncResource.bind() because it calls ObjectDefineProperties which
-        // is a bottleneck here.
-        callback = bindAsyncResource(callback, 'STREAM_END_OF_STREAM');
-      }
-      process.nextTick(() => callback.call(stream, ...args));
-    }
-  };
   let cleanup = () => {
     callback = nop;
   };
@@ -207,23 +194,27 @@ function eos(stream, options, callback) {
         stream.removeListener('error', nop);
       };
     }
-    returnImmediately(immediateResult);
-    return cleanup;
+  } else if (options.signal?.aborted) {
+    immediateResult = new AbortError(undefined, { cause: options.signal.reason });
   }
-
-  if (options.signal?.aborted) {
-    returnImmediately(new AbortError(undefined, { cause: options.signal.reason }));
+  if (immediateResult !== undefined && options[kEosNodeSyncronousCallback]) {
+    ReflectApply(callback, stream, immediateResult === null ? [] : [immediateResult]);
     return cleanup;
   }
 
   if (AsyncContextFrame.current() || enabledHooksExist()) {
     // Avoid AsyncResource.bind() because it calls ObjectDefineProperties which
     // is a bottleneck here.
-    callback = once(bindAsyncResource(callback, 'STREAM_END_OF_STREAM'));
-  } else {
-    callback = once(callback);
+    callback = bindAsyncResource(callback, 'STREAM_END_OF_STREAM');
   }
 
+  if (immediateResult !== undefined) {
+    process.nextTick(() => ReflectApply(callback, stream, immediateResult === null ? [] : [immediateResult]));
+    return cleanup;
+  }
+
+  callback = once(callback);
+
   const onlegacyfinish = () => {
     if (!stream.writable) {
       onfinish();