http: remove abort listener and add test for server-side req.signal.aborted on client disconnect

Author: akshatsrivastava11

lib/_http_incoming.js

@@ -201,9 +201,6 @@ ObjectDefineProperty(IncomingMessage.prototype, 'signal', {
         this.once('close', function() {
           ac.abort();
         });
-        this.once('abort', function() {
-          ac.abort();
-        });
       }
     }
     return this[kAbortController].signal;

test/parallel/test-http-request-signal.js

@@ -34,16 +34,8 @@ const http = require('http');
   assert.strictEqual(req.signal, req.signal);
 }
 
-// Test 4: req.signal aborts when 'abort' event is emitted on req
-{
-  const req = new http.IncomingMessage(null);
-  const signal = req.signal;
-  assert.strictEqual(signal.aborted, false);
-  req.emit('abort');
-  assert.strictEqual(signal.aborted, true);
-}
 
-// Test 5: res.signal on a client-side http.request() response (IncomingMessage).
+// Test 4: res.signal on a client-side http.request() response (IncomingMessage).
 {
   const server = http.createServer(common.mustCall((req, res) => {
     res.writeHead(200);
@@ -68,3 +60,26 @@ const http = require('http');
     clientReq.end();
   }));
 }
+
+// Test 5: Client cancels a pending request.
+{
+  const server = http.createServer(common.mustCall((req, res) => {
+    req.signal.onabort = common.mustCall(() => {
+      assert.strictEqual(req.signal.aborted, true);
+      server.close();
+    });
+    res.flushHeaders();
+  }));
+
+  server.listen(0, common.mustCall(() => {
+    const clientReq = http.request(
+      { port: server.address().port },
+      common.mustCall((res) => {
+        res.on('error', () => {});
+        clientReq.destroy();
+      }),
+    );
+    clientReq.on('error', () => {});
+    clientReq.end();
+  }));
+}