review fixed

Author: mertcanaltin

src/node_sqlite.cc

@@ -819,7 +819,8 @@ Intercepted DatabaseSyncLimits::LimitsQuery(
   }
 
   // Property exists and is writable
-  info.GetReturnValue().Set(Integer::New(isolate, v8::PropertyAttribute::DontDelete));
+  info.GetReturnValue().Set(
+      Integer::New(isolate, v8::PropertyAttribute::DontDelete));
   return Intercepted::kYes;
 }
 
@@ -950,12 +951,8 @@ bool DatabaseSync::Open() {
   sqlite3_busy_timeout(connection_, open_config_.get_timeout());
 
   // Apply initial limits
-  const auto& limits = open_config_.initial_limits();
-  for (size_t limit_id = 0; limit_id < limits.size(); ++limit_id) {
-    if (limits[limit_id].has_value()) {
-      sqlite3_limit(
-          connection_, static_cast<int>(limit_id), limits[limit_id].value());
-    }
+  for (const auto& [limit_id, limit_value] : open_config_.initial_limits()) {
+    sqlite3_limit(connection_, limit_id, limit_value);
   }
 
   if (allow_load_extension_) {

src/node_sqlite.h

@@ -93,11 +93,10 @@ class DatabaseOpenConfiguration {
   inline bool get_enable_defensive() const { return defensive_; }
 
   inline void set_initial_limit(int limit_id, int value) {
-    initial_limits_.at(limit_id) = value;
+    initial_limits_[limit_id] = value;
   }
 
-  inline const std::array<std::optional<int>, kLimitMapping.size()>&
-  initial_limits() const {
+  inline const std::map<int, int>& initial_limits() const {
     return initial_limits_;
   }
 
@@ -112,7 +111,7 @@ class DatabaseOpenConfiguration {
   bool allow_bare_named_params_ = true;
   bool allow_unknown_named_params_ = false;
   bool defensive_ = true;
-  std::array<std::optional<int>, kLimitMapping.size()> initial_limits_;
+  std::map<int, int> initial_limits_;
 };
 
 class DatabaseSync;