internal: improve formatting for network errors with IPv6 addresses and ports

Author: mraerino

lib/internal/errors.js

@@ -698,7 +698,8 @@ class UVExceptionWithHostPort extends Error {
     let details = '';
 
     if (port && port > 0) {
-      details = ` ${address}:${port}`;
+      const host = address.includes(':') ? `[${address}]` : address; // RFC 5952 Section 6
+      details = ` ${host}:${port}`;
     } else if (address) {
       details = ` ${address}`;
     }

test/parallel/test-net-autoselectfamily-commandline-option.js

@@ -32,14 +32,14 @@ const { createConnection, createServer } = require('net');
 
       if (common.hasIPv6) {
         assert.strictEqual(error.code, 'ECONNREFUSED');
-        assert.strictEqual(error.message, `connect ECONNREFUSED ::1:${port}`);
+        assert.strictEqual(error.message, `connect ECONNREFUSED [::1]:${port}`);
       } else if (error.code === 'EAFNOSUPPORT') {
-        assert.strictEqual(error.message, `connect EAFNOSUPPORT ::1:${port} - Local (undefined:undefined)`);
+        assert.strictEqual(error.message, `connect EAFNOSUPPORT [::1]:${port} - Local (undefined:undefined)`);
       } else if (error.code === 'EUNATCH') {
-        assert.strictEqual(error.message, `connect EUNATCH ::1:${port} - Local (:::0)`);
+        assert.strictEqual(error.message, `connect EUNATCH [::1]:${port} - Local ([::]:0)`);
       } else {
         assert.strictEqual(error.code, 'EADDRNOTAVAIL');
-        assert.strictEqual(error.message, `connect EADDRNOTAVAIL ::1:${port} - Local (:::0)`);
+        assert.strictEqual(error.message, `connect EADDRNOTAVAIL [::1]:${port} - Local ([::]:0)`);
       }
 
       ipv4Server.close();

test/parallel/test-net-autoselectfamily-default.js

@@ -67,14 +67,14 @@ const autoSelectFamilyAttemptTimeout = common.defaultAutoSelectFamilyAttemptTime
     connection.on('error', common.mustCall((error) => {
       if (common.hasIPv6) {
         assert.strictEqual(error.code, 'ECONNREFUSED');
-        assert.strictEqual(error.message, `connect ECONNREFUSED ::1:${port}`);
+        assert.strictEqual(error.message, `connect ECONNREFUSED [::1]:${port}`);
       } else if (error.code === 'EAFNOSUPPORT') {
-        assert.strictEqual(error.message, `connect EAFNOSUPPORT ::1:${port} - Local (undefined:undefined)`);
+        assert.strictEqual(error.message, `connect EAFNOSUPPORT [::1]:${port} - Local (undefined:undefined)`);
       } else if (error.code === 'EUNATCH') {
-        assert.strictEqual(error.message, `connect EUNATCH ::1:${port} - Local (:::0)`);
+        assert.strictEqual(error.message, `connect EUNATCH [::1]:${port} - Local ([::]:0)`);
       } else {
         assert.strictEqual(error.code, 'EADDRNOTAVAIL');
-        assert.strictEqual(error.message, `connect EADDRNOTAVAIL ::1:${port} - Local (:::0)`);
+        assert.strictEqual(error.message, `connect EADDRNOTAVAIL [::1]:${port} - Local ([::]:0)`);
       }
 
       ipv4Server.close();

test/parallel/test-net-autoselectfamily.js

@@ -177,7 +177,7 @@ if (common.hasIPv6) {
     assert.ok(errors.includes('connect ECONNREFUSED 127.0.0.1:10'));
 
     if (common.hasIPv6) {
-      assert.ok(errors.includes('connect ECONNREFUSED ::1:10'));
+      assert.ok(errors.includes('connect ECONNREFUSED [::1]:10'));
     }
   }));
 }
@@ -207,14 +207,14 @@ if (common.hasIPv6) {
 
       if (common.hasIPv6) {
         assert.strictEqual(error.code, 'ECONNREFUSED');
-        assert.strictEqual(error.message, `connect ECONNREFUSED ::1:${port}`);
+        assert.strictEqual(error.message, `connect ECONNREFUSED [::1]:${port}`);
       } else if (error.code === 'EAFNOSUPPORT') {
-        assert.strictEqual(error.message, `connect EAFNOSUPPORT ::1:${port} - Local (undefined:undefined)`);
+        assert.strictEqual(error.message, `connect EAFNOSUPPORT [::1]:${port} - Local (undefined:undefined)`);
       } else if (error.code === 'EUNATCH') {
-        assert.strictEqual(error.message, `connect EUNATCH ::1:${port} - Local (:::0)`);
+        assert.strictEqual(error.message, `connect EUNATCH [::1]:${port} - Local ([::]:0)`);
       } else {
         assert.strictEqual(error.code, 'EADDRNOTAVAIL');
-        assert.strictEqual(error.message, `connect EADDRNOTAVAIL ::1:${port} - Local (:::0)`);
+        assert.strictEqual(error.message, `connect EADDRNOTAVAIL [::1]:${port} - Local ([::]:0)`);
       }
 
       ipv4Server.close();