vfs: restore isExperimentalSeaWarningNeeded as a function

Reverts the change that converted isExperimentalSeaWarningNeeded from
a SetMethod (function) to a boolean property in the sea binding. This
keeps mksnapshot.js unchanged from upstream.

Author: mcollina

lib/internal/main/embedding.js

@@ -37,8 +37,8 @@ const path = require('path');
 // command line (e.g. it could be provided via an API or bundled into the executable).
 prepareMainThreadExecution(false, true);
 
-const isBuiltinWarningNeeded = isLoadingSea && isExperimentalSeaWarningNeeded;
-if (isExperimentalSeaWarningNeeded) {
+const isBuiltinWarningNeeded = isLoadingSea && isExperimentalSeaWarningNeeded();
+if (isExperimentalSeaWarningNeeded()) {
   emitExperimentalWarning('Single executable application');
 }
 

lib/internal/main/mksnapshot.js

@@ -202,7 +202,7 @@ function main() {
     return fn(requireForUserSnapshot, filename, dirname);
   }
 
-  if (isExperimentalSeaWarningNeeded) {
+  if (isExperimentalSeaWarningNeeded()) {
     emitExperimentalWarning('Single executable application');
   }
 

lib/internal/modules/helpers.js

@@ -144,7 +144,7 @@ let isSEABuiltinWarningNeeded_;
 function isSEABuiltinWarningNeeded() {
   if (isSEABuiltinWarningNeeded_ === undefined) {
     const { isExperimentalSeaWarningNeeded, isSea } = internalBinding('sea');
-    isSEABuiltinWarningNeeded_ = isSea && isExperimentalSeaWarningNeeded;
+    isSEABuiltinWarningNeeded_ = isSea && isExperimentalSeaWarningNeeded();
   }
   return isSEABuiltinWarningNeeded_;
 }

src/node_sea.cc

@@ -259,7 +259,23 @@ SeaResource FindSingleExecutableResource() {
   return sea_resource;
 }
 
-// Boolean flag getters removed - flags are set as properties in Initialize().
+void IsExperimentalSeaWarningNeeded(const FunctionCallbackInfo<Value>& args) {
+  bool is_building_sea =
+      !per_process::cli_options->experimental_sea_config.empty();
+  if (is_building_sea) {
+    args.GetReturnValue().Set(true);
+    return;
+  }
+
+  if (!IsSingleExecutable()) {
+    args.GetReturnValue().Set(false);
+    return;
+  }
+
+  SeaResource sea_resource = FindSingleExecutableResource();
+  args.GetReturnValue().Set(!static_cast<bool>(
+      sea_resource.flags & SeaFlags::kDisableExperimentalSeaWarning));
+}
 
 std::tuple<int, char**> FixupArgsForSEA(int argc, char** argv) {
   // Repeats argv[0] at position 1 on argv as a replacement for the missing
@@ -886,17 +902,11 @@ void Initialize(Local<Object> target,
   // Set boolean flags as properties (computed once, avoids repeated calls).
   bool is_sea = IsSingleExecutable();
   bool is_vfs_enabled = false;
-  bool is_experimental_warning_needed =
-      !per_process::cli_options->experimental_sea_config.empty();
 
   if (is_sea) {
     SeaResource sea_resource = FindSingleExecutableResource();
     is_vfs_enabled =
         static_cast<bool>(sea_resource.flags & SeaFlags::kEnableVfs);
-    if (!static_cast<bool>(sea_resource.flags &
-                           SeaFlags::kDisableExperimentalSeaWarning)) {
-      is_experimental_warning_needed = true;
-    }
   }
 
   target
@@ -909,17 +919,17 @@ void Initialize(Local<Object> target,
             FIXED_ONE_BYTE_STRING(isolate, "isVfsEnabled"),
             Boolean::New(isolate, is_vfs_enabled))
       .Check();
-  target
-      ->Set(context,
-            FIXED_ONE_BYTE_STRING(isolate, "isExperimentalSeaWarningNeeded"),
-            Boolean::New(isolate, is_experimental_warning_needed))
-      .Check();
 
+  SetMethod(context,
+            target,
+            "isExperimentalSeaWarningNeeded",
+            IsExperimentalSeaWarningNeeded);
   SetMethod(context, target, "getAsset", GetAsset);
   SetMethod(context, target, "getAssetKeys", GetAssetKeys);
 }
 
 void RegisterExternalReferences(ExternalReferenceRegistry* registry) {
+  registry->Register(IsExperimentalSeaWarningNeeded);
   registry->Register(GetAsset);
   registry->Register(GetAssetKeys);
 }