lib: reject SharedArrayBuffer in web APIs per spec

Signed-off-by: Ali Hassan <ali-hassan27@outlook.com>

Author: thisalihassan

lib/internal/blob.js

@@ -45,6 +45,7 @@ const {
 const {
   isAnyArrayBuffer,
   isArrayBufferView,
+  isSharedArrayBuffer,
 } = require('internal/util/types');
 
 const {
@@ -109,6 +110,21 @@ function getSource(source, endings) {
   if (isBlob(source))
     return [source.size, source[kHandle]];
 
+  if (isSharedArrayBuffer(source)) {
+    throw new ERR_INVALID_ARG_TYPE(
+      'source',
+      ['ArrayBuffer', 'TypedArray', 'DataView', 'Blob', 'string'],
+      source,
+    );
+  }
+  if (isArrayBufferView(source) && isSharedArrayBuffer(source.buffer)) {
+    throw new ERR_INVALID_ARG_VALUE(
+      'source',
+      source,
+      'must not be backed by a SharedArrayBuffer',
+    );
+  }
+
   if (isAnyArrayBuffer(source)) {
     source = new Uint8Array(source);
   } else if (!isArrayBufferView(source)) {

lib/internal/crypto/webidl.js

@@ -31,6 +31,7 @@ const {
 } = primordials;
 
 const {
+  converters: sharedConverters,
   makeException,
   createEnumConverter,
   createSequenceConverter,
@@ -43,11 +44,10 @@ const {
 } = require('internal/util');
 const { CryptoKey } = require('internal/crypto/webcrypto');
 const {
-  getDataViewOrTypedArrayBuffer,
   validateMaxBufferLength,
   kNamedCurveAliases,
 } = require('internal/crypto/util');
-const { isArrayBuffer, isSharedArrayBuffer } = require('internal/util/types');
+const { isSharedArrayBuffer } = require('internal/util/types');
 
 // https://tc39.es/ecma262/#sec-tonumber
 function toNumber(value, opts = kEmptyObject) {
@@ -193,8 +193,6 @@ converters.object = (V, opts) => {
   return V;
 };
 
-const isNonSharedArrayBuffer = isArrayBuffer;
-
 /**
  * @param {string | object} V - The hash algorithm identifier (string or object).
  * @param {string} label - The dictionary name for the error message.
@@ -223,25 +221,7 @@ converters.Uint8Array = (V, opts = kEmptyObject) => {
   return V;
 };
 
-converters.BufferSource = (V, opts = kEmptyObject) => {
-  if (ArrayBufferIsView(V)) {
-    if (isSharedArrayBuffer(getDataViewOrTypedArrayBuffer(V))) {
-      throw makeException(
-        'is a view on a SharedArrayBuffer, which is not allowed.',
-        opts);
-    }
-
-    return V;
-  }
-
-  if (!isNonSharedArrayBuffer(V)) {
-    throw makeException(
-      'is not instance of ArrayBuffer, Buffer, TypedArray, or DataView.',
-      opts);
-  }
-
-  return V;
-};
+converters.BufferSource = sharedConverters.BufferSource;
 
 converters['sequence<DOMString>'] = createSequenceConverter(
   converters.DOMString);

lib/internal/webidl.js

@@ -1,8 +1,10 @@
 'use strict';
 
 const {
+  ArrayBufferIsView,
   ArrayPrototypePush,
   ArrayPrototypeToSorted,
+  DataViewPrototypeGetBuffer,
   MathAbs,
   MathMax,
   MathMin,
@@ -19,6 +21,7 @@ const {
   Symbol,
   SymbolIterator,
   TypeError,
+  TypedArrayPrototypeGetBuffer,
 } = primordials;
 
 const {
@@ -28,6 +31,11 @@ const {
   },
 } = require('internal/errors');
 const { kEmptyObject } = require('internal/util');
+const {
+  isArrayBuffer,
+  isDataView,
+  isSharedArrayBuffer,
+} = require('internal/util/types');
 
 const converters = { __proto__: null };
 
@@ -382,6 +390,47 @@ function createInterfaceConverter(name, I) {
   };
 }
 
+function getDataViewOrTypedArrayBuffer(V) {
+  return isDataView(V) ?
+    DataViewPrototypeGetBuffer(V) : TypedArrayPrototypeGetBuffer(V);
+}
+
+// https://webidl.spec.whatwg.org/#ArrayBufferView
+converters.ArrayBufferView = (V, opts = kEmptyObject) => {
+  if (!ArrayBufferIsView(V)) {
+    throw makeException(
+      'is not an ArrayBufferView.',
+      opts);
+  }
+  if (isSharedArrayBuffer(getDataViewOrTypedArrayBuffer(V))) {
+    throw makeException(
+      'is a view on a SharedArrayBuffer, which is not allowed.',
+      opts);
+  }
+
+  return V;
+};
+
+// https://webidl.spec.whatwg.org/#BufferSource
+converters.BufferSource = (V, opts = kEmptyObject) => {
+  if (ArrayBufferIsView(V)) {
+    if (isSharedArrayBuffer(getDataViewOrTypedArrayBuffer(V))) {
+      throw makeException(
+        'is a view on a SharedArrayBuffer, which is not allowed.',
+        opts);
+    }
+
+    return V;
+  }
+
+  if (!isArrayBuffer(V)) {
+    throw makeException(
+      'is not instance of ArrayBuffer, Buffer, TypedArray, or DataView.',
+      opts);
+  }
+
+  return V;
+};
 
 module.exports = {
   type,

lib/internal/webstreams/compression.js

@@ -26,6 +26,7 @@ const {
 const {
   codes: {
     ERR_INVALID_ARG_TYPE,
+    ERR_INVALID_ARG_VALUE,
   },
 } = require('internal/errors');
 
@@ -40,13 +41,20 @@ function lazyZlib() {
 // Per the Compression Streams spec, chunks must be BufferSource
 // (ArrayBuffer or ArrayBufferView not backed by SharedArrayBuffer).
 function validateBufferSourceChunk(chunk) {
-  if (isArrayBufferView(chunk) && isSharedArrayBuffer(chunk.buffer)) {
+  if (isSharedArrayBuffer(chunk)) {
     throw new ERR_INVALID_ARG_TYPE(
       'chunk',
       ['ArrayBuffer', 'Buffer', 'TypedArray', 'DataView'],
       chunk,
     );
   }
+  if (isArrayBufferView(chunk) && isSharedArrayBuffer(chunk.buffer)) {
+    throw new ERR_INVALID_ARG_VALUE(
+      'chunk',
+      chunk,
+      'must not be backed by a SharedArrayBuffer',
+    );
+  }
 }
 
 const formatConverter = createEnumConverter('CompressionFormat', [

lib/internal/webstreams/readablestream.js

@@ -48,6 +48,7 @@ const {
 const {
   isArrayBufferView,
   isDataView,
+  isSharedArrayBuffer,
 } = require('internal/util/types');
 
 const {
@@ -988,6 +989,15 @@ class ReadableStreamBYOBReader {
 
     const viewByteLength = ArrayBufferViewGetByteLength(view);
     const viewBuffer = ArrayBufferViewGetBuffer(view);
+
+    if (isSharedArrayBuffer(viewBuffer)) {
+      throw new ERR_INVALID_ARG_VALUE(
+        'view',
+        view,
+        'must not be backed by a SharedArrayBuffer',
+      );
+    }
+
     const viewBufferByteLength = ArrayBufferPrototypeGetByteLength(viewBuffer);
 
     if (viewByteLength === 0 || viewBufferByteLength === 0) {
@@ -1197,6 +1207,15 @@ class ReadableByteStreamController {
     validateBuffer(chunk);
     const chunkByteLength = ArrayBufferViewGetByteLength(chunk);
     const chunkBuffer = ArrayBufferViewGetBuffer(chunk);
+
+    if (isSharedArrayBuffer(chunkBuffer)) {
+      throw new ERR_INVALID_ARG_VALUE(
+        'chunk',
+        chunk,
+        'must not be backed by a SharedArrayBuffer',
+      );
+    }
+
     const chunkBufferByteLength = ArrayBufferPrototypeGetByteLength(chunkBuffer);
     if (chunkByteLength === 0 || chunkBufferByteLength === 0) {
       throw new ERR_INVALID_STATE.TypeError(