Skip to content

Commit 1af9e54

Browse files
committed
squash! nits
1 parent 731953b commit 1af9e54

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

tools/nix/v8.nix

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
lib,
55
patchutils,
66
validatePkgConfig,
7-
nodejs-slim_latest,
87
icu,
98

109
buildInputs ? lib.optional (icu != null) icu,
@@ -17,6 +16,7 @@
1716
)
1817
],
1918

19+
nodejs-slim_latest ? null,
2020
configureScript ? nodejs-slim_latest.configureScript,
2121
nativeBuildInputs ? nodejs-slim_latest.nativeBuildInputs,
2222
patches ? nodejs-slim_latest.patches,
@@ -120,9 +120,13 @@ stdenv.mkDerivation (finalAttrs: {
120120
];
121121

122122
buildPhase = ''
123+
runHook preBuild
123124
ninja -v -C out/Release v8_snapshot v8_libplatform
125+
runHook postBuild
124126
'';
125127
installPhase = ''
128+
runHook preInstall
129+
126130
${
127131
if stdenv.hostPlatform.isDarwin then
128132
# Darwin is excluded from creating thin archive in tools/gyp/pylib/gyp/generator/ninja.py:2488
@@ -156,5 +160,7 @@ stdenv.mkDerivation (finalAttrs: {
156160
done) -lstdc++
157161
Cflags: -I${v8Dir}/include -I${v8Dir}/third_party/abseil-cpp -I${v8Dir}/third_party/simdutf
158162
EOF
163+
164+
runHook postInstall
159165
'';
160166
})

0 commit comments

Comments
 (0)