fix: use more strict compiler flags

Author: anonrig

BUILD.bazel

@@ -17,6 +17,13 @@ cc_library(
     name = "ncrypto",
     srcs = glob(["src/*.cpp"]),
     hdrs = glob(["include/*.h", "include/ncrypto/*.h"]),
+    copts = [
+        "-Werror",
+        "-Wextra",
+        "-Wno-unused-parameter",
+        "-Wimplicit-fallthrough",
+        "-Wno-deprecated-declarations",  # OpenSSL 3.0 deprecates many APIs we intentionally use
+    ],
     includes = ["include"],
     local_defines = {
         "NCRYPTO_BSSL_LIBDECREPIT_MISSING": select(

include/ncrypto/aead.h

@@ -19,7 +19,7 @@ class Aead final {
 
  public:
   Aead() = default;
-  Aead(const AeadInfo* info, const EVP_AEAD* aead) : info_(info), aead_(aead) {}
+  Aead(const AeadInfo* info, const EVP_AEAD* aead) : aead_(aead), info_(info) {}
   Aead(const Aead&) = default;
   Aead& operator=(const Aead&) = default;
   NCRYPTO_DISALLOW_MOVE(Aead)

src/CMakeLists.txt

@@ -1,4 +1,19 @@
 add_library(ncrypto ncrypto.cpp engine.cpp aead.cpp)
+
+# Enable strict warning flags for ncrypto sources only
+if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang|AppleClang")
+    target_compile_options(ncrypto PRIVATE
+        -Werror
+        -Wextra
+        -Wno-unused-parameter
+        -Wimplicit-fallthrough
+        -Wno-deprecated-declarations  # OpenSSL 3.0 deprecates many APIs we intentionally use
+    )
+endif()
+if(MSVC)
+    target_compile_options(ncrypto PRIVATE /WX /W4)
+endif()
+
 if (NCRYPTO_SHARED_LIBS)
     target_link_libraries(ncrypto PUBLIC OpenSSL::SSL OpenSSL::Crypto)
 else()