API allows rerequesting approval of approved files

[lukasdotcom]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

---

Steps to reproduce

1. User test1 uploads a file
2. User test1 sends approval request via UI
3. User test2 approves the file
4. User test1 can rerequest approval in the api

Expected behaviour

User test1 can't do that.

Actual behaviour

User test1 can do that.

Server configuration

Web server: Apache/Nginx

Database: MySQL/Maria/SQLite/PostgreSQL

PHP version: 8.2/8.3/8.4

Nextcloud version: (see Nextcloud admin page)

List of activated apps

If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your Nextcloud installation folder

Nextcloud configuration

If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your Nextcloud installation folder

Browser

Browser name: Firefox/Chrome/Safari/…

Browser version: 124/125/…

Operating system: Windows/Ubuntu/Mac/…

Browser log

Insert your browser log here, this could for example include:
a) The javascript console log
b) The network log
c) ...

[Amitdwivedi22]

Hi @lukasdotcom ,
I’d like to work on this issue.
I believe this can be fixed by adding a validation check to prevent re-requesting approval once a file is already approved.
Please assign this issue to me.