From fc9a643464b6896c4b3067468e6f264e680fb0a6 Mon Sep 17 00:00:00 2001 From: Gonzalo Martinez Lema Date: Tue, 22 Apr 2025 12:14:29 +0200 Subject: [PATCH 1/3] Update platform on GHA --- .github/workflows/test_suite.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test_suite.yml b/.github/workflows/test_suite.yml index cc2330b8..6d73a3a5 100644 --- a/.github/workflows/test_suite.yml +++ b/.github/workflows/test_suite.yml @@ -14,7 +14,7 @@ jobs: matrix: python-version: [3.8] #platform: [ubuntu-18.04, macos-latest] - platform: [ubuntu-20.04] + platform: [ubuntu-24.04] runs-on: ${{ matrix.platform }} steps: @@ -28,8 +28,8 @@ jobs: run: | cd .. git clone https://github.com/next-exp/IC.git - - + + - name: Run tests run: | cd .. @@ -38,4 +38,4 @@ jobs: source manage.sh work_in_python_version_no_tests ${{ matrix.python-version }} cd ../ICAROS source icaro_setup.sh - PYTEST_ADDOPTS=--color=yes HYPOTHESIS_PROFILE=travis-ci pytest -v \ No newline at end of file + PYTEST_ADDOPTS=--color=yes HYPOTHESIS_PROFILE=travis-ci pytest -v From 42572518e4f622e410fff50215dae2e7cf31fe44 Mon Sep 17 00:00:00 2001 From: Gonzalo Martinez Lema Date: Tue, 22 Apr 2025 16:28:40 +0200 Subject: [PATCH 2/3] Update subtype of catched Exception in fit_lifetime_unbinned For some reason the exception no longer has a type LinAlgError, but rather SystemError. --- krcal/core/fit_lt_functions.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/krcal/core/fit_lt_functions.py b/krcal/core/fit_lt_functions.py index ecc5dde7..4fa72d84 100644 --- a/krcal/core/fit_lt_functions.py +++ b/krcal/core/fit_lt_functions.py @@ -274,7 +274,7 @@ def fit_lifetime_unbined(z : np.array, logging.warn(f'Type error found in fit_lifetime_unbined: not enough events for fit') valid = False - except LinAlgError: + except SystemError: logging.warn(f'LinAlgError error found in fit_lifetime_unbined: not enough events for fit') valid = False From dadce6304fcac5ea948bd008dfe4dd5d4974363e Mon Sep 17 00:00:00 2001 From: Gonzalo Martinez Lema Date: Fri, 18 Jul 2025 11:27:45 +0200 Subject: [PATCH 3/3] Update checkout version on GHA --- .github/workflows/test_suite.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test_suite.yml b/.github/workflows/test_suite.yml index 6d73a3a5..60b68a30 100644 --- a/.github/workflows/test_suite.yml +++ b/.github/workflows/test_suite.yml @@ -18,7 +18,7 @@ jobs: runs-on: ${{ matrix.platform }} steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v4 - name: Get LFS files run: git lfs pull # - name: Fix Conda permissions on macOS