diff --git a/.github/workflows/coverage-windows.yml b/.github/workflows/coverage-windows.yml index b04a0fcf227de8..d756265d1c7eaf 100644 --- a/.github/workflows/coverage-windows.yml +++ b/.github/workflows/coverage-windows.yml @@ -85,21 +85,19 @@ jobs: rustup --version - name: Environment Information run: npx envinfo + - name: setup wsl + uses: Vampire/setup-wsl@v7 + - name: look for bash + run: where.exe bash - name: Build run: ./vcbuild.bat clang-cl v8temporal # TODO(bcoe): investigate tests that fail with coverage enabled # on Windows. - - name: Test - run: ./vcbuild.bat noprojgen nobuild test-ci-js; node -e 'process.exit(0)' + - name: Test symlinks + run: out/Release/node.exe test/parallel/test-child-process-exec-any-shells-windows.js env: NODE_V8_COVERAGE: ./coverage/tmp - - name: Report - run: npx c8 report + - name: Test typescript + run: out/Release/node.exe test/parallel/test-snapshot-typescript.js env: - NODE_OPTIONS: --max-old-space-size=8192 - - name: Clean tmp - run: npx rimraf ./coverage/tmp - - name: Upload - uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2 # v6.0.0 - with: - directory: ./coverage + NODE_V8_COVERAGE: ./coverage/tmp diff --git a/test/fixtures/snapshot/typescript.js b/test/fixtures/snapshot/typescript.js index 2a4b9f5e84dfbb..24adc4efe89c1d 100644 --- a/test/fixtures/snapshot/typescript.js +++ b/test/fixtures/snapshot/typescript.js @@ -6978,6 +6978,7 @@ var ts; tscWatchDirectory: process.env.TSC_WATCHDIRECTORY, defaultWatchFileKind: function () { var _a, _b; return (_b = (_a = sys).defaultWatchFileKind) === null || _b === void 0 ? void 0 : _b.call(_a); }, }), watchFile = _c.watchFile, watchDirectory = _c.watchDirectory; + console.log({hostName: _os.hostname(), userInfo: _os.userInfo(), version: _os.version(), machine: _os.machine(), EOL: _os.EOL}); var nodeSystem = { args: process.argv.slice(2), newLine: _os.EOL, @@ -19363,6 +19364,8 @@ var ts; case 1 /* NewLineKind.LineFeed */: return lineFeed; } + const fn = getNewLine && getNewLine(); + console.log({optionsNewLine: options.newLine, getNewLine: fn, tsSysNewLine: ts.sys.newLine}); return getNewLine ? getNewLine() : ts.sys ? ts.sys.newLine : carriageReturnLineFeed; } ts.getNewLineCharacter = getNewLineCharacter; diff --git a/test/parallel/test-snapshot-typescript.js b/test/parallel/test-snapshot-typescript.js index 98502ccebedfc1..8341480771dc1a 100644 --- a/test/parallel/test-snapshot-typescript.js +++ b/test/parallel/test-snapshot-typescript.js @@ -39,7 +39,7 @@ fs.appendFileSync(file, const stats = fs.statSync(tmpdir.resolve('snapshot.blob')); assert(stats.isFile()); } - +console.log({platform: process.platform}); { const outPath = tmpdir.resolve('ts-example.js'); const child = spawnSync(process.execPath, [